From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52570A034F; Mon, 22 Feb 2021 18:09:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D40B840041; Mon, 22 Feb 2021 18:09:13 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 805684003C for ; Mon, 22 Feb 2021 18:09:12 +0100 (CET) IronPort-SDR: xp4XBRdkmYbzb0oYJksHY8bsmXImW4Px24peFmSLPPjmzO6M36OjwOjmg07vsdLBLmCA+2Zj14 Dpfo/HK2KSdg== X-IronPort-AV: E=McAfee;i="6000,8403,9903"; a="245942794" X-IronPort-AV: E=Sophos;i="5.81,197,1610438400"; d="scan'208";a="245942794" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2021 09:09:10 -0800 IronPort-SDR: kN5si0qNFwtkLttCdDFZ0SYql4e7tjg1+DKQXn1G+FPwRk0x7I2brfzXc1l2xp6XVIi17aRhp6 9OOnNw8Xvsmw== X-IronPort-AV: E=Sophos;i="5.81,197,1610438400"; d="scan'208";a="498629679" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.216.168]) ([10.213.216.168]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2021 09:09:09 -0800 From: Ferruh Yigit To: Andrew Boyer , Thomas Monjalon Cc: dev , Alfredo Cardigliano References: <20210129224434.71536-1-aboyer@pensando.io> <4842644.BW4ZEuPtVA@thomas> <2ea7be7f-1f7c-ff26-fc52-5372e58bad92@intel.com> X-User: ferruhy Message-ID: <2f8f6082-450d-5854-ed96-e07383f7a6c4@intel.com> Date: Mon, 22 Feb 2021 17:09:05 +0000 MIME-Version: 1.0 In-Reply-To: <2ea7be7f-1f7c-ff26-fc52-5372e58bad92@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net: redefine array size macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/2/2021 12:30 PM, Ferruh Yigit wrote: > On 2/1/2021 10:32 PM, Andrew Boyer wrote: >> >> >>> On Feb 1, 2021, at 5:28 PM, Thomas Monjalon >> > wrote: >>> >>> 29/01/2021 23:44, Andrew Boyer: >>>> Replace copies of size(arr)/size(arr[0]) with RTE_DIM(). >>>> Eventually all of these macro definitions should be removed. >>>> >>>> Signed-off-by: Andrew Boyer > >>>> --- >>>> drivers/net/atlantic/atl_hw_regs.h                | 2 +- >>>> drivers/net/axgbe/axgbe_common.h                  | 2 +- >>>> drivers/net/bnx2x/bnx2x.h                         | 2 +- >>>> drivers/net/bnx2x/elink.h                         | 2 +- >>>> drivers/net/ena/ena_ethdev.c                      | 2 +- >>>> drivers/net/enic/base/vnic_devcmd.h               | 2 +- >>>> drivers/net/hns3/hns3_ethdev.h                    | 2 +- >>>> drivers/net/i40e/base/i40e_osdep.h                | 2 +- >>>> drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h | 2 +- >>>> drivers/net/thunderx/base/nicvf_hw.h              | 2 +- >>>> 10 files changed, 10 insertions(+), 10 deletions(-) >>> >>> Thanks for the cleanup. >>> >>> In the title, the prefix "net" means librte_net. >>> Here, it should be "drivers/net". I know it's confusing :) >>> >>> Please check other patches in the series, >>> they are versioned as v2 and numbered 4/13 and 6/13. >> >> Thank you for the review - do you want me to resend or can you fix it up >> yourself? >> > > I can fix the title while merging, thanks for cleanup, > > Reviewed-by: Ferruh Yigit > Applied to dpdk-next-net/main, thanks. Patch title updated as: "drivers/net: redefine array size macros"