From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Matan Azrad <matan@mellanox.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add return value to stats get dev op
Date: Tue, 10 Oct 2017 00:57:40 +0100 [thread overview]
Message-ID: <2fc68f86-1b71-7cbb-01c9-5ab52437faac@intel.com> (raw)
In-Reply-To: <1507565524-18590-1-git-send-email-matan@mellanox.com>
On 10/9/2017 5:12 PM, Matan Azrad wrote:
> The stats_get dev op API doesn't include return value, so PMD cannot
> return an error in case of failure at stats getting process time.
>
> Since PCI devices can be removed and there is a time between the
> physical removal to the RMV interrupt, the user may get invalid stats
> without any indication.
>
> This patch changes the stats_get API return value to be int instead of
> void.
>
> All the net PMDs stats_get dev ops are adjusted by this patch.
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
Hi Matan,
Can you please rebase on top of latest next-net?
There are new PMDs in repo not covered by your patch:
- dpaa
- octeontx
- mrvl
- (perhaps softnic, waiting an updated version of it)
Thanks,
ferruh
next prev parent reply other threads:[~2017-10-09 23:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 16:12 Matan Azrad
2017-10-09 16:12 ` [dpdk-dev] [PATCH 2/2] doc: update stats get API change Matan Azrad
2017-10-09 21:07 ` Thomas Monjalon
2017-10-09 23:57 ` Ferruh Yigit [this message]
2017-10-10 20:20 ` [dpdk-dev] [PATCH v2] ethdev: add return value to stats get dev op Matan Azrad
2017-10-11 2:01 ` Ferruh Yigit
2017-10-11 2:09 ` Ferruh Yigit
2017-10-11 10:46 ` Thomas Monjalon
2017-10-11 13:09 ` Andrew Rybchenko
2017-10-11 13:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fc68f86-1b71-7cbb-01c9-5ab52437faac@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).