From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02A2742B90; Wed, 24 May 2023 20:47:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9535240ED8; Wed, 24 May 2023 20:47:07 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 5A3AE40156 for ; Wed, 24 May 2023 20:47:05 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id D08633200B96; Wed, 24 May 2023 14:47:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 24 May 2023 14:47:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1684954023; x=1685040423; bh=HB5L/TgJ8tJNEEHEgX/uqJnZp3440wHqRwH poow57bo=; b=RV1owGHFWsxa4LN37YEL1jkZYljiB+bp8SvPn0+ZrV00BhnXNjd lIecW05uPJoebqF8KzfyoIeTO2x0BQzf8Mcudz+Q9RvgBZQf5QO3Xs1Wh/wQ0obR 1LrlRphaunUUH5KfpfcAbNhpDLo7VjvNwH9F908kofU4kpKxHMB+AtXZNxtCO7C+ 6VlyEhQEB6NXvlmlKnQX1nm0DzI3iSYXYXcipBVUyCjzCE0S4OsXsQHl1dUBwIx4 htAjtAVMPbzKZfOmPmN/BJQ/44N/LbXoGJqZNqvHCyPBFzaiy/lMGUDJWB6BCSd9 13W1Arhebhem9ydhSccRrhjlZgRXMVdB5tw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1684954023; x=1685040423; bh=HB5L/TgJ8tJNEEHEgX/uqJnZp3440wHqRwH poow57bo=; b=HVifX/uqr8mxewvvle8rk+PvYmfCYD6m9jqcFm3TM9IQN+EUvmY 61RTrSPEo9csA0d16ibP4F35Vou2QB0cY9FPFea2rpk96uch1C5oIkg0MrZyiiGu ok6RdDtKpVWvfqvmDgcz/B22v80nf4av2rai6IzKUht54QDmR1cXOLEWPW3faASr h+yJ0ASVPfG4tG3Cf8GnAZ6NUrKaPWThO/jpxrgr+d/sr6hOBztisHSzk90oDOvz LgGCQgV8i3ANI+jtQakZRMxGE2w/vSCeAm54b5smVlmAUnLLRgnUtNNCsH0de3Pu wABJfv3pQseFmaWDTJqZJy6jsp6aiUc8p7Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejhedguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 May 2023 14:47:02 -0400 (EDT) From: Thomas Monjalon To: Sivaprasad Tummala Cc: david.hunt@intel.com, dev@dpdk.org, ferruh.yigit@amd.com, anatoly.burakov@intel.com, "Laatz, Kevin" Subject: Re: [PATCH v1] power: support amd-pstate cpufreq driver Date: Wed, 24 May 2023 20:46:59 +0200 Message-ID: <3000723.687JKscXgg@thomas> In-Reply-To: <20230412095244.967182-1-Sivaprasad.Tummala@amd.com> References: <20230412095244.967182-1-Sivaprasad.Tummala@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/04/2023 11:52, Sivaprasad Tummala: > amd-pstate introduces a new CPU frequency control mechanism for AMD > processors using the ACPI Collaborative Performance Power Control > feature for a finer grained frequency management. > > Patch to add support for amd-pstate driver. > > Signed-off-by: Sivaprasad Tummala > --- > app/test/test_power.c | 1 + > app/test/test_power_cpufreq.c | 5 +- > doc/guides/rel_notes/release_23_07.rst | 3 + > examples/l3fwd-power/main.c | 1 + > lib/power/meson.build | 1 + > lib/power/power_amd_pstate_cpufreq.c | 698 +++++++++++++++++++++++++ > lib/power/power_amd_pstate_cpufreq.h | 219 ++++++++ > lib/power/rte_power.c | 26 + > lib/power/rte_power.h | 3 +- > lib/power/rte_power_pmd_mgmt.c | 6 +- > 10 files changed, 958 insertions(+), 5 deletions(-) I'm not comfortable to merge this patch without a word from David Hunt. Given there is 0 review, what do we do? > Also, make sure to start the actual text at the margin. > ======================================================= > > + * **Added amd-pstate driver support to power management library.** > + > + Added support for amd-pstate driver which works on AMD Zen processors. Looks like the indent is not correct. > 'power_pstate_cpufreq.c', > + 'power_amd_pstate_cpufreq.c', Can you say briefly why AMD has a different pstate? Does it mean power_pstate_cpufreq.c should be renamed power_intel_pstate_cpufreq.c? > +++ b/lib/power/power_amd_pstate_cpufreq.c > @@ -0,0 +1,698 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2010-2021 Intel Corporation > + * Copyright(c) 2021 Arm Limited Why is there copyright for Intel and Arm? Does it mean you copied some code and did not try to keep common code in a common place? > + * Copyright(c) 2023 Amd Limited