Re: [PATCH v1] net/iavf: fix resource leak issue

[Thomas Monjalon <thomas@monjalon.net>]

17/05/2022 02:59, Zhang, Qi Z:
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 12/05/2022 02:20, Zhang, Qi Z:
> > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > 11/05/2022 17:31, Zhang, Qi Z:
> > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > 11/05/2022 13:46, Zhang, Qi Z:
> > > > > > > > From: Wu, Wenjun1 <wenjun1.wu@intel.com>
> > > > > > > > >
> > > > > > > > > This patch fixes resource leak issue reported by coverity.
> > > > > > > > >
> > > > > > > > > Coverity issue: 378017
> > > > > > > > > Fixes: b14e8a57b9fe ("net/iavf: support quanta size
> > > > > > > > > configuration")
> > > > > > > > >
> > > > > > > > > Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
> > > > > > > >
> > > > > > > > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> > > > > > > >
> > > > > > > > Applied to dpdk-next-net-intel.
> > > > > > >
> > > > > > > In the title, the word "issue" is useless.
> > > > > > > It would be more interesting to precise where is the leak.
> > > > > > >
> > > > > >
> > > > > > Added below into commit log in dpdk-next-net-intel.
> > > > > >
> > > > > > kvlist should be freed before return an error due to invalid quanta size.
> > > > >
> > > > > It does not explain what is the scenario. What is the impacted feature?
> > > >
> > > > I think the scenario has been explained as
> > > >
> > > > "kvlist should be freed before return an error due to invalid quanta size"
> > > > the impact has been mentioned as "resource leak" I guess this is how
> > > > Coverity describe the issue
> > >
> > > No, it does not say how to reproduce (the scenario).
> > > We have no idea where it is in the code.
> > 
> > set an invalid quanta size from devargs will reproduce the issue
> > >
> > >
> Refine the Title / commit log in dpdk-next-net-intel as below to answer Thomas's questions
> 
> net/iavf: fix memory leak issue

A memory leak is an issue for sure, so no need to add "issue".

> Set an invalid quanta size from devargs will cause memory leak and this

Set -> Setting

> is reported by coverity.
> 
> The patch fix the issue by correcting the error handle.

handle -> handling

Thanks