DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "Wu, Wenjun1" <wenjun1.wu@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [PATCH v1] net/iavf: fix resource leak issue
Date: Tue, 17 May 2022 08:52:07 +0200	[thread overview]
Message-ID: <3000980.U7HbjWM52l@thomas> (raw)
In-Reply-To: <DM4PR11MB5994CEB465147747DDE28245D7CE9@DM4PR11MB5994.namprd11.prod.outlook.com>

17/05/2022 02:59, Zhang, Qi Z:
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 12/05/2022 02:20, Zhang, Qi Z:
> > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > 11/05/2022 17:31, Zhang, Qi Z:
> > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > 11/05/2022 13:46, Zhang, Qi Z:
> > > > > > > > From: Wu, Wenjun1 <wenjun1.wu@intel.com>
> > > > > > > > >
> > > > > > > > > This patch fixes resource leak issue reported by coverity.
> > > > > > > > >
> > > > > > > > > Coverity issue: 378017
> > > > > > > > > Fixes: b14e8a57b9fe ("net/iavf: support quanta size
> > > > > > > > > configuration")
> > > > > > > > >
> > > > > > > > > Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
> > > > > > > >
> > > > > > > > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> > > > > > > >
> > > > > > > > Applied to dpdk-next-net-intel.
> > > > > > >
> > > > > > > In the title, the word "issue" is useless.
> > > > > > > It would be more interesting to precise where is the leak.
> > > > > > >
> > > > > >
> > > > > > Added below into commit log in dpdk-next-net-intel.
> > > > > >
> > > > > > kvlist should be freed before return an error due to invalid quanta size.
> > > > >
> > > > > It does not explain what is the scenario. What is the impacted feature?
> > > >
> > > > I think the scenario has been explained as
> > > >
> > > > "kvlist should be freed before return an error due to invalid quanta size"
> > > > the impact has been mentioned as "resource leak" I guess this is how
> > > > Coverity describe the issue
> > >
> > > No, it does not say how to reproduce (the scenario).
> > > We have no idea where it is in the code.
> > 
> > set an invalid quanta size from devargs will reproduce the issue
> > >
> > >
> Refine the Title / commit log in dpdk-next-net-intel as below to answer Thomas's questions
> 
> net/iavf: fix memory leak issue

A memory leak is an issue for sure, so no need to add "issue".

> Set an invalid quanta size from devargs will cause memory leak and this

Set -> Setting

> is reported by coverity.
> 
> The patch fix the issue by correcting the error handle.

handle -> handling

Thanks



  reply	other threads:[~2022-05-17  6:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10  0:54 Wenjun Wu
2022-05-11 11:46 ` Zhang, Qi Z
2022-05-11 14:52   ` Thomas Monjalon
2022-05-11 15:31     ` Zhang, Qi Z
2022-05-11 21:17       ` Thomas Monjalon
2022-05-12  0:20         ` Zhang, Qi Z
2022-05-12  7:06           ` Thomas Monjalon
2022-05-12  7:21             ` Zhang, Qi Z
2022-05-17  0:59               ` Zhang, Qi Z
2022-05-17  6:52                 ` Thomas Monjalon [this message]
2022-05-18  4:55                   ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3000980.U7HbjWM52l@thomas \
    --to=thomas@monjalon.net \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=wenjun1.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).