From: Thomas Monjalon <thomas@monjalon.net>
To: "Wu, Jingjing" <jingjing.wu@intel.com>,
"Li, Xiaoyun" <xiaoyun.li@intel.com>
Cc: dev@dpdk.org, stephen@networkplumber.com
Subject: Re: [dpdk-dev] [PATCH v3] examples/l3fwd: pass flow arguments when start app
Date: Tue, 24 Oct 2017 23:44:55 +0200 [thread overview]
Message-ID: <3004385.aZoaESbhz5@xps> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810E9FA64@SHSMSX103.ccr.corp.intel.com>
24/10/2017 03:38, Wu, Jingjing:
> From: Li, Xiaoyun
> > To make the performance can be tuning on different NICs or platforms. We
> > need to make the number of descriptors as arguments when starting l3fwd
> > application.
> >
> > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
>
> Agree to this change.
>
> Reviewed-by: Jingjing Wu <jingjing.wu@intel.com>
As Stephen, I disagree.
I agree that it may be convenient to test performance tuning.
But it is the purpose of testpmd, not l3fwd example.
This change shows that we need to improve defaults.
I will block this patch in order to get someone working on improvements
in ethdev and drivers.
prev parent reply other threads:[~2017-10-24 21:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 2:31 [dpdk-dev] [PATCH] examples/l3fwd: pass flow arguments when starting l3fwd Xiaoyun Li
2017-09-30 1:59 ` [dpdk-dev] [PATCH v2] examples/l3fwd: pass flow arguments when start app Xiaoyun Li
2017-10-01 17:24 ` Stephen Hemminger
2017-10-05 8:35 ` Wu, Jingjing
2017-10-10 7:57 ` Wu, Jingjing
2017-10-18 7:11 ` [dpdk-dev] [PATCH v3] " Xiaoyun Li
2017-10-24 1:38 ` Wu, Jingjing
2017-10-24 21:44 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3004385.aZoaESbhz5@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stephen@networkplumber.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).