From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 8A1071B89A for ; Tue, 24 Oct 2017 23:44:57 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id ECA5A208A4; Tue, 24 Oct 2017 17:44:56 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 24 Oct 2017 17:44:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=VgPAXKU1FYNG9MGZHk114Ks1iL oz+bsHcVcTNBeqClw=; b=AEjJtHn+kCZ8W5VdA4irh91rVpXUy/sTRfZ7dWsMtl Spsi52VYIkQW7bQ86X23bZggjQgqEHMS9QVLi1MBsAdXJrEAJ5Bqpcu/6cWFEae8 qUvq951DZceu+4rfkm4B2aqgx1pLYhvqrX1mCMLSn94RWpbfnpnM3JdF8uAOxIXw E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=VgPAXK U1FYNG9MGZHk114Ks1iLoz+bsHcVcTNBeqClw=; b=d3QPlo2eTQOfu1rdbZL8Lo omVtpV3Mx5zAv3DSpOXGK7iEsnDN0hJ3qussiJf273jTtdEztYJajDJAS8fT3tgP 3r1m83xDs2CiLOcHNDiIn5fFFhS/ADzaI9HDmqAQp0c/DMYgmPuxYn6H9jDJ9gDg zwzKNb8I0SUXDlZ2SzWL1vd3MQblpe76uFwbSK8FROAaLcdK9Wc0bFxMdz9cUPbi ls1TmQdekzFosGAwgsWF3T86hbHniBcjygk1PyCo/JffRw91JHwhdyrw8FepDubP Gxk7nbTIGZhSA5NHnG9/S+cvj8cVvKynAFRR5oYRKCL9MGcbNKY3fUZT5QVaCb5w == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A1A6024009; Tue, 24 Oct 2017 17:44:56 -0400 (EDT) From: Thomas Monjalon To: "Wu, Jingjing" , "Li, Xiaoyun" Cc: dev@dpdk.org, stephen@networkplumber.com Date: Tue, 24 Oct 2017 23:44:55 +0200 Message-ID: <3004385.aZoaESbhz5@xps> In-Reply-To: <9BB6961774997848B5B42BEC655768F810E9FA64@SHSMSX103.ccr.corp.intel.com> References: <1506736748-50515-1-git-send-email-xiaoyun.li@intel.com> <1508310691-34865-1-git-send-email-xiaoyun.li@intel.com> <9BB6961774997848B5B42BEC655768F810E9FA64@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] examples/l3fwd: pass flow arguments when start app X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 21:44:57 -0000 24/10/2017 03:38, Wu, Jingjing: > From: Li, Xiaoyun > > To make the performance can be tuning on different NICs or platforms. We > > need to make the number of descriptors as arguments when starting l3fwd > > application. > > > > Signed-off-by: Xiaoyun Li > > Agree to this change. > > Reviewed-by: Jingjing Wu As Stephen, I disagree. I agree that it may be convenient to test performance tuning. But it is the purpose of testpmd, not l3fwd example. This change shows that we need to improve defaults. I will block this patch in order to get someone working on improvements in ethdev and drivers.