From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 693C94CA2 for ; Tue, 18 Sep 2018 11:40:32 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0147821ECD; Tue, 18 Sep 2018 05:40:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 18 Sep 2018 05:40:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=sXHXdtGOImJzDSbjjc14Z7a8Gk jN/D+mBIfC5SK4jro=; b=gt0pjKKYtrfnosvQTjQ24/x+2x9PKGJGrAoU8eoEE0 jtrjmg8k5KPWPJOkuJAjQhput9sODSppHDLH9r9ye5G4cecMh1lx3ULfw1Zee73O aRJdUtQ4osB+Kpr0rmr1FSPijj6BToLWPIsUOQYRv1Rwgy0QNEomc7Z7Aujg+Zec Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=sXHXdt GOImJzDSbjjc14Z7a8GkjN/D+mBIfC5SK4jro=; b=Uvn8vldvxZgcih3GTmZVtA jt+/6UMzoNkf9I6R+xxu9WKx6yo0xbZ6XPO9wZIAz7atWtvT4/ahQNZ/a1z03RYp IDrigbNNHPUtJfJphXhUJxhncEpatDEFf3g3nmlcB2Um+vzcB8Y67I7TLkpVWV0z FFh2WMF8Js34qeH1bCVAmS17K8e0v7AD6v7LP7+u4BMz0lJtvxNNJAWYwZzjHKp/ Cr6YeZsvUBZ3vFl3ndPQv/e2AYoQAypnv72Y6G22od3o6GFP0z45zJRK52J2yEQC 2KfatHObp9W3V+BfnM7jDMohbaVAEMwsAAmvgHddvcOd6Dyhr7cPqA0HzgmVBmEQ == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A3E4E102D3; Tue, 18 Sep 2018 05:40:30 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Stephen Hemminger , Harish Patil , Rasesh Mody Date: Tue, 18 Sep 2018 11:40:28 +0200 Message-ID: <3009159.xGyNxZp9MA@xps> In-Reply-To: <20180725182019.31518-3-stephen@networkplumber.org> References: <20180725182019.31518-1-stephen@networkplumber.org> <20180725182019.31518-3-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 09:40:32 -0000 25/07/2018 20:20, Stephen Hemminger: > No need for profanity in comments. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/bnx2x/elink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c > index 34a29373af3b..08fe817720a1 100644 > --- a/drivers/net/bnx2x/elink.c > +++ b/drivers/net/bnx2x/elink.c > @@ -3993,11 +3993,11 @@ static elink_status_t elink_get_mod_abs_int_cfg(struct bnx2x_softc *sc, > PORT_HW_CFG_E3_MOD_ABS_MASK) >> > PORT_HW_CFG_E3_MOD_ABS_SHIFT; > > - /* Should not happen. This function called upon interrupt > + /* > + * Should not happen. This function called upon interrupt > * triggered by GPIO ( since EPIO can only generate interrupts > * to MCP). > * So if this function was called and none of the GPIOs was set, > - * it means the shit hit the fan. > */ It makes the comment ends with a comma, like the end is missing.