From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id 154B6326B for ; Tue, 4 Apr 2017 12:27:08 +0200 (CEST) Received: by mail-wr0-f170.google.com with SMTP id k6so203465278wre.2 for ; Tue, 04 Apr 2017 03:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=CooGsECMHgqgI+NfdD3hhsu/n2QBNBXVvocDEv7ltOI=; b=uhJ4Y6mckc/vu4iCQjwbv1G4Gfl3fGOl881N4q50BDoGKpuSEUWZmhdVJqJtZjba9a r+4oRpL+8cQwuYUu0hh7fhAaK4x+QQumXrlMC8XcREDV84uOCltHyRPeivW81g8bJaP+ yFda/ipAOHIXRB75WahyinhhIsTO7bOWSCRzLNEyC15DceWaViaECHNBd0VnTtyZQbsu hvb9k61ZvdiewxDJzydZyym875Ty71t40/uwklms1Yza/FhpE7qdrKYEpHntul2CYVvs sVZ7N9kqUx6hjJj0jMl8zGhdza5+qyShhoN/OcmV/mrOCYiJjMGw4FXrJzWLaNh/wHlc 23cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=CooGsECMHgqgI+NfdD3hhsu/n2QBNBXVvocDEv7ltOI=; b=UgGuw8/V6IA04VCZQOoajVLw7V7G1v7/BcSbTYWGyjo3ywVW3vQ0+BAMmGp6GvMtGk dcl3wSP5MGtrhmNMQkEyHKKZOCUrP3a3LX7qPS/rhrKD5+2C/1NP7RkonoQh2TghPIV3 FbnjMZDt12L+haHveMx4yTLq4a+uvXLAKoTlGMh+JN2wRzcUWrHvYGmop/bSe/H39lQR bGLAlodD0mPrWRg1EWXF3t7eBbEgHjvGOvWuaHO561v2cfMZHqgws2FHiw3RtGHUGyY0 03mU2Zfhx0MZMlLnb5Cl7jTdrYcOrg+X7uCf3M0I1LdQ09i/fQ4vqm+CIb8PpVocFLu4 Ya/Q== X-Gm-Message-State: AFeK/H1f+5dSdzwMXDh4OW0Asul1l5XgmNsbouGJdUIOpcEVdl5XEG41RcD9d14dA9qZ5pM2 X-Received: by 10.223.169.113 with SMTP id u104mr18473812wrc.168.1491301627808; Tue, 04 Apr 2017 03:27:07 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id v108sm21698403wrc.41.2017.04.04.03.27.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 03:27:07 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org Date: Tue, 04 Apr 2017 12:27:05 +0200 Message-ID: <3012960.JsXpb7kNfE@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170324143011.29279-1-bruce.richardson@intel.com> References: <20170324143011.29279-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal/bsdapp: fix device binding at boot X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 10:27:08 -0000 2017-03-24 14:30, Bruce Richardson: > When loading nic_uio from /boot/loader.conf as specified in the Getting > Started Guide doc, the NIC devices were not bound at boot. Unloading the > nic_uio driver and reloading it would cause them to be bound, however. > > The root cause appears to be the fact that when the module is loaded at > boot, the call to find the pci device when parsing the b:d:f parameter > fails to return the device. That means that later on when the device > is probed as part of a PCI scan, no action is taken as it's not recorded > as a device to be used. > > We fix this by having the b:d:f string parsed again on probe if the > initial check to see if it's an already-known device fails. In my tests, > this causes the NIC devices to be successfully bound at boot time, as > well as leaving things working as before in the case the module is loaded > post-boot. > > Fixes: 764bf26873b9 ("add FreeBSD support") > > Signed-off-by: Bruce Richardson Cc: stable@dpdk.org Applied, thanks