From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 251FCA327F for ; Mon, 21 Oct 2019 18:07:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 345C21BF14; Mon, 21 Oct 2019 18:07:32 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 0FBE11BF12 for ; Mon, 21 Oct 2019 18:07:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2019 09:07:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,324,1566889200"; d="scan'208";a="209382849" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by orsmga002.jf.intel.com with ESMTP; 21 Oct 2019 09:07:27 -0700 From: Ferruh Yigit To: "Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)" Cc: "dev@dpdk.org" , Stephen Hemminger , "damarion@cisco.com" References: <20190709082254.12698-1-jgrajcia@cisco.com> <20190822081833.11203-1-jgrajcia@cisco.com> <0a3d8d8a-c66b-4015-3c63-6b14ee350651@intel.com> <519478de-25d7-729a-9ece-b1612b86e0ed@intel.com> <95cc597b-8369-54de-9407-add5b2306f48@intel.com> <782b6d35-b1c4-71c3-afd0-96116b364b3d@intel.com> Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <3018de3b-1783-8265-94bf-749e0535562f@intel.com> Date: Mon, 21 Oct 2019 17:07:26 +0100 MIME-Version: 1.0 In-Reply-To: <782b6d35-b1c4-71c3-afd0-96116b364b3d@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5] net/memif: zero-copy slave X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/17/2019 5:45 PM, Ferruh Yigit wrote: > On 10/17/2019 5:04 PM, Ferruh Yigit wrote: >> On 10/17/2019 12:52 PM, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at >> Cisco) wrote: >>> >>>> Hi Jakub, >>>> >>>> Just to double check if anyone is looking into the bind() error issue which is >>>> since following commit, I am waiting for more input on it. >>>> >>>> Commit b923866c6974 ("net/memif: allow for full key size in socket name") >>>> Cc: stephen@networkplumber.org >>> >>> Definitely an issue, I must have messed something up while applying the patch for testing, as it's not working for me either. I looked into bind() and it seems that the size has upper limit. Are you able to revert the patch? >> >> +1 to logically revert the patch, but actually I think it is easier to do an >> incremental patch on top of current head to fix the issue. >> >> The patch replaces hard-coded 'key_len' to a macro which is good to keep, also >> number of lines needs to be changed for fix looks less than number of lines will >> be changed by revert J >> >>> >>> As for the issue that patch addresses, there is an incorrect information in the docs that 'socket' parameter length is 256b. It should be 108b as that is the limitation on Linux. >> >> I don't know the doc but code has it as 256b [1] and the issue patch addresses >> looks like a valid issue. If you are OK to limit the 'key_len' to 108 [2], the >> fix is really easy. > > Hi Jakub, > > Something like following seems fixing the issue, can you please make a patch for > the fix? Ping. Can it possible to make this on time so rc1 doesn't released with broken PMD? Thanks, ferruh > > > > diff --git a/drivers/net/memif/memif_socket.c b/drivers/net/memif/memif_socket.c > index 0c71f6c454..aa4f549f2c 100644 > --- a/drivers/net/memif/memif_socket.c > +++ b/drivers/net/memif/memif_socket.c > @@ -868,8 +868,7 @@ memif_socket_create(struct pmd_internals *pmd, > const char *key, uint8_t listener) > { > struct memif_socket *sock; > - struct sockaddr_un *un; > - char un_buf[MEMIF_SOCKET_UN_SIZE]; > + struct sockaddr_un un; > int sockfd; > int ret; > int on = 1; > @@ -889,16 +888,14 @@ memif_socket_create(struct pmd_internals *pmd, > if (sockfd < 0) > goto error; > > - memset(un_buf, 0, sizeof(un_buf)); > - un = (struct sockaddr_un *)un_buf; > - un->sun_family = AF_UNIX; > - strlcpy(un->sun_path, sock->filename, MEMIF_SOCKET_KEY_LEN); > + un.sun_family = AF_UNIX; > + strlcpy(un.sun_path, sock->filename, MEMIF_SOCKET_KEY_LEN); > > ret = setsockopt(sockfd, SOL_SOCKET, SO_PASSCRED, &on, > sizeof(on)); > if (ret < 0) > goto error; > - ret = bind(sockfd, (struct sockaddr *)un, MEMIF_SOCKET_UN_SIZE); > + ret = bind(sockfd, (struct sockaddr *)&un, sizeof(struct > sockaddr_un)); > if (ret < 0) > goto error; > ret = listen(sockfd, 1); > diff --git a/drivers/net/memif/memif_socket.h b/drivers/net/memif /memif_socket.h > index 9f40f8d138..12fa123230 100644 > --- a/drivers/net/memif/memif_socket.h > +++ b/drivers/net/memif/memif_socket.h > @@ -79,7 +79,7 @@ struct memif_socket_dev_list_elt { > }; > > #define MEMIF_SOCKET_HASH_NAME "memif-sh" > -#define MEMIF_SOCKET_KEY_LEN 256 > +#define MEMIF_SOCKET_KEY_LEN 100 > > struct memif_socket { > struct rte_intr_handle intr_handle; /**< interrupt handle */ > > > >> >> >> [1] >> http://lxr.dpdk.org/dpdk/v19.08/source/drivers/net/memif/memif_socket.h#L84 >> >> [2] >> If I remember correctly the suggested length was 99 for portability, it seems >> different OS has this value different and 99 is the smallest ... >> >