From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23DB74550B; Thu, 27 Jun 2024 15:52:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0D5440E09; Thu, 27 Jun 2024 15:52:25 +0200 (CEST) Received: from fhigh4-smtp.messagingengine.com (fhigh4-smtp.messagingengine.com [103.168.172.155]) by mails.dpdk.org (Postfix) with ESMTP id 85F9240BA3 for ; Thu, 27 Jun 2024 15:52:24 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.nyi.internal (Postfix) with ESMTP id F24E311401BA; Thu, 27 Jun 2024 09:52:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 27 Jun 2024 09:52:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1719496343; x=1719582743; bh=5W81IObadcqDxYTq7LNfPyCoScGHZjbwIvKS+WhCWB8=; b= nXE8LJwWkf2ymXTv3+0ENX7B8SWImzvjGKod+Ux4NJ7O+r3werXXDhMxukRrV4AO guUhBzGvMpTRDbH1KK61VRuBwvgCSED7dOn3Tz6dYo+YOBUJ7RkNVU+MDQjpLs/c /0KJTZKBmIN3DygIueoO9LKpdP2f2Tg6JK9mQD9u/sLh8HEWMj9deYeyOJjz9f2M gRTefKW0yyVuyEAp5twsbEPkz0JdkmMHR8weo/XD14hXKE89+BU/SUS3PwRShjVz yPzNwY1CikR++CEA/ZjxQ1GdDrrVAT9eS3vxPhb5yMJMYfhLxrHW6Dvs02RS5UNq +BrkZew+zTa6vUCPpjO47Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1719496343; x= 1719582743; bh=5W81IObadcqDxYTq7LNfPyCoScGHZjbwIvKS+WhCWB8=; b=t gJ1lBUcwpNYoP7nqazjZEZeufjy5bUiTxC8TrEKYO2+WhzZEVDLQzDEOW7UPWd1e PAvxaQm9y4GGsH18oxym1je7zw4AsNaFkd9M1ilh08WDofuO7H0wfzKuEzWpp1mU EesPub+T6C5CSiwV0IczBpT8sPE2CxAJJHWYY1i+GlzffO9RC0n3KNxWr4LwwRS6 szVq6lCtX3nWiE+vtHXHKUHXpbHa2Xow6ghOcWsWZHabhUz84r0vPQoX/++tXaB1 wHcfZTTwl9/UQ5jJ/VpLqV3zIxHdnLnT+QNf0o2SCaDuxmetxTWTGVonKk5TiI2I GwgGLj9/juueVIPNOsS/Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrtdeggdejtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeegkefg vdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 27 Jun 2024 09:52:22 -0400 (EDT) From: Thomas Monjalon To: "Wu, Jingjing" Cc: "dev@dpdk.org" , "jerinj@marvell.com" , "pbhagavatula@marvell.com" , "Yan, Zhirun" Subject: Re: [PATCH v2] graph: fix head move when graph walk in mcore dispatch Date: Thu, 27 Jun 2024 15:52:21 +0200 Message-ID: <3019171.aBcLfjPe96@thomas> In-Reply-To: References: <20240319141454.3275543-1-jingjing.wu@intel.com> <20240322154637.1346239-1-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 28/03/2024 09:32, Yan, Zhirun: > From: Wu, Jingjing > > --- a/lib/graph/rte_graph_model_mcore_dispatch.h > > +++ b/lib/graph/rte_graph_model_mcore_dispatch.h > > @@ -100,9 +100,8 @@ rte_graph_walk_mcore_dispatch(struct rte_graph > > *graph) > > node = (struct rte_node *)RTE_PTR_ADD(graph, > > cir_start[(int32_t)head++]); > > > > /* skip the src nodes which not bind with current worker */ > > - if ((int32_t)head < 0 && node->dispatch.lcore_id != graph- > > >dispatch.lcore_id) > > + if ((int32_t)head < 1 && node->dispatch.lcore_id != > > +graph->dispatch.lcore_id) > > continue; > > - > No need for this line. > > > /* Schedule the node until all task/objs are done */ > > if (node->dispatch.lcore_id != RTE_MAX_LCORE && > > graph->dispatch.lcore_id != node->dispatch.lcore_id && > > -- > > 2.34.1 > > With small change, > > Acked-by: Zhirun Yan Applied with above change, thanks.