DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] graph: fix head move when graph walk in mcore dispatch
@ 2024-03-19 14:14 Jingjing Wu
  2024-03-20  3:33 ` Yan, Zhirun
  2024-03-22 15:46 ` [PATCH v2] " Jingjing Wu
  0 siblings, 2 replies; 9+ messages in thread
From: Jingjing Wu @ 2024-03-19 14:14 UTC (permalink / raw)
  To: dev; +Cc: jingjing.wu, jerinj, pbhagavatula, zhirun.yan, stable

Head move should happen after the core id check, otherwise
source node will be missed.

Fixes: 35dfd9b9fd85 ("graph: introduce graph walk by cross-core dispatch")
Cc: stable@dpdk.org

Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
 lib/graph/rte_graph_model_mcore_dispatch.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/graph/rte_graph_model_mcore_dispatch.h b/lib/graph/rte_graph_model_mcore_dispatch.h
index 75ec388cad..b96469296e 100644
--- a/lib/graph/rte_graph_model_mcore_dispatch.h
+++ b/lib/graph/rte_graph_model_mcore_dispatch.h
@@ -97,12 +97,12 @@ rte_graph_walk_mcore_dispatch(struct rte_graph *graph)
 		__rte_graph_mcore_dispatch_sched_wq_process(graph);
 
 	while (likely(head != graph->tail)) {
-		node = (struct rte_node *)RTE_PTR_ADD(graph, cir_start[(int32_t)head++]);
+		node = (struct rte_node *)RTE_PTR_ADD(graph, cir_start[(int32_t)head]);
 
 		/* skip the src nodes which not bind with current worker */
 		if ((int32_t)head < 0 && node->dispatch.lcore_id != graph->dispatch.lcore_id)
 			continue;
-
+		head++;
 		/* Schedule the node until all task/objs are done */
 		if (node->dispatch.lcore_id != RTE_MAX_LCORE &&
 		    graph->dispatch.lcore_id != node->dispatch.lcore_id &&
-- 
2.34.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-06-27 13:52 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-19 14:14 [PATCH] graph: fix head move when graph walk in mcore dispatch Jingjing Wu
2024-03-20  3:33 ` Yan, Zhirun
2024-03-20  6:25   ` Wu, Jingjing
2024-03-20  8:42     ` Yan, Zhirun
2024-03-21  3:39       ` Wu, Jingjing
2024-03-21  5:34         ` Yan, Zhirun
2024-03-22 15:46 ` [PATCH v2] " Jingjing Wu
2024-03-28  8:32   ` Yan, Zhirun
2024-06-27 13:52     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).