Re: [PATCH 07/17] net/dpaa: share MAC FMC scheme and CC parse

[Hemant Agrawal <hemant.agrawal@oss.nxp.com>]

On 07-08-2024 21:09, Ferruh Yigit wrote:
> On 8/1/2024 11:53 AM, Hemant Agrawal wrote:
>> From: Jun Yang <jun.yang@nxp.com>
>>
>> For Shared MAC:
>> 1) Allocate RXQ from VSP scheme.
>> 2) Allocate RXQ from CC directed to VSP.
>>
> What is CC, please explain in the commit log.
Coarse Classification to determine VSP (VF)
>> 2) Remove RXQ allocated which is reconfigured without VSP.
>> 3) Don't alloc default queue and err queues.
>>
>> Signed-off-by: Jun Yang <jun.yang@nxp.com>
>> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> <...>
>
>> diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c
>> index c15538116d..bbccd2a89b 100644
>> --- a/drivers/net/dpaa/dpaa_rxtx.c
>> +++ b/drivers/net/dpaa/dpaa_rxtx.c
>> @@ -693,13 +693,26 @@ dpaa_rx_cb_atomic(void *event,
>>   }
>>   
>>   #ifdef RTE_LIBRTE_DPAA_DEBUG_DRIVER
>> -static inline void dpaa_eth_err_queue(struct dpaa_if *dpaa_intf)
>> +static inline void
>> +dpaa_eth_err_queue(struct qman_fq *fq)
>>   {
>>   	struct rte_mbuf *mbuf;
>>   	struct qman_fq *debug_fq;
>>   	int ret, i;
>>   	struct qm_dqrr_entry *dq;
>>   	struct qm_fd *fd;
>> +	struct dpaa_if *dpaa_intf;
>> +
>> +	dpaa_intf = fq->dpaa_intf;
>> +	if (fq != &dpaa_intf->rx_queues[0]) {
>> +		/** Associate error queues to the first RXQ.*/
>> +		return;
>> +	}
>> +
>> +	if (dpaa_intf->cfg->fman_if->is_shared_mac) {
>> +		/** Error queues of shared MAC are handled in kernel. */
>>
> This is doxygen syntax, is using '/** ' instead of '/* ' intentional?

It was not intentional.  The code is coming from a baremetal env. We 
have fixed it now.


>
> <...>