From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 780FDA09FF; Wed, 6 Jan 2021 10:22:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F166E1608E4; Wed, 6 Jan 2021 10:22:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 974341608E1 for ; Wed, 6 Jan 2021 10:22:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609924957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aNLNy1c750nw9jYpzpvlE5Mn+v28pW179e70WRe2t0k=; b=MXusrNy5KtzTt0RRbEy35i/bDN0ExUW7J7DWPc/H4Kx/jPHRnGvnrFJVH6GuRPTrBP+bzl xKJgDAXq/o1uN165Gvg41MhHXK+mLo42r9PP4u5gXSifOc1j6yHi2zSLFRyi6U5Ob29JRi vc9jFNfMdNkmz6hpMp17cidZ3jYp6q8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-105-dSINK6g2Pwm987nsVK-L1A-1; Wed, 06 Jan 2021 04:22:35 -0500 X-MC-Unique: dSINK6g2Pwm987nsVK-L1A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0043D800D55; Wed, 6 Jan 2021 09:22:34 +0000 (UTC) Received: from [10.36.110.9] (unknown [10.36.110.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 800E77047A; Wed, 6 Jan 2021 09:22:19 +0000 (UTC) To: Thomas Monjalon , David Marchand Cc: Ray Kinsella , dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata References: <20201220211405.313012-1-maxime.coquelin@redhat.com> <20201220211405.313012-9-maxime.coquelin@redhat.com> <13089839.ugh3R6DZUH@thomas> From: Maxime Coquelin Message-ID: <301ef4b6-d95f-6007-da08-9faa435b2075@redhat.com> Date: Wed, 6 Jan 2021 10:22:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <13089839.ugh3R6DZUH@thomas> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 08/40] net/virtio: force IOVA as VA mode for Virtio-user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/6/21 10:11 AM, Thomas Monjalon wrote: > 06/01/2021 10:06, David Marchand: >> On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin >> wrote: >>> diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c >>> index 1f1f63a1a5..f4775ff141 100644 >>> --- a/drivers/net/virtio/virtio_user_ethdev.c >>> +++ b/drivers/net/virtio/virtio_user_ethdev.c >>> @@ -663,6 +663,17 @@ virtio_user_pmd_probe(struct rte_vdev_device *vdev) >>> char *mac_addr = NULL; >>> int ret = -1; >>> >>> + /* >>> + * ToDo 1: Implement detection mechanism at vdev bus level as PCI, but >>> + * it implies API breakage. >> >> Extending rte_vdev_driver to implement this detection would be an ABI breakage. >> This is a driver-only API (rte_vdev_driver is only used by the vdev >> bus and drivers afaics). >> >> Doing this is allowed as per my understanding of the ABI policy which >> guarantees ABI stability for applications. >> We do not guarantee this stability for OOT drivers. > > I agree. > As a reminder, the A in ABI stands for Application. Cool, so we're all good. Thanks for the prompt reply! Maxime