From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 3BEB434F3 for ; Tue, 13 Nov 2018 17:37:48 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 87BB6211D3; Tue, 13 Nov 2018 11:37:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 13 Nov 2018 11:37:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=sUcqWujKdN9D10RcoDflMSHuNp5qk9N83RSQn9F7yxo=; b=CqzJPFV0E1xM dQqZ3Kg5vO84onGbbuAm0ve4wsQ/SOd3XLZO1xqHyTYUJJQ5lXTr9y5ovtTAVr1m AGddC5ITTvuZnyoU4P40pF6Myh11JVmpp+nfdVNZmGRw0lVrVrgT6yLj1+Un2775 nt06lZ4gktfDIrkXPPpBHZKCeVqIqHI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=sUcqWujKdN9D10RcoDflMSHuNp5qk9N83RSQn9F7y xo=; b=QbjycvWUZTkx8PIhS57mcxb4n6KByKdR0ApIaQMW4flxOlVpG4JZ1gfpE 4fEgVANEnF4AhUSoC6FZkht2kk+LPpulcyNr4VHUms0jx2Ei1ndCl6+1RsSTJmTt OJ0DH2cijs208gfSEZa9yHEayVRWrhtbpJ0Klzz2R11QboXk70Is/Avk58miQ0un pS2UL87BChxinYDGO9oh4MUvoU1LBnS7cZ7SkaWyZ4rt21i8iuog08X5DZ+tR6Tm MApFI1VwIqmYHJJW7GInURnwi5+lD1rdFC4Osau+LPliaXVUffupr1oxEda3Hg+w PBeDl5bRLqUzGXKEFzqTVc7g4U+oA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BFBAE102A0; Tue, 13 Nov 2018 11:37:45 -0500 (EST) From: Thomas Monjalon To: Honnappa Nagarahalli Cc: dev@dpdk.org, Jerin Jacob , "bruce.richardson@intel.com" , "pablo.de.lara.guarch@intel.com" , "hemant.agrawal@nxp.com" , "chaozhu@linux.vnet.ibm.com" , "yipeng1.wang@intel.com" , "dharmik.thakkar@arm.com" , "gavin.hu@arm.com" , "nd@arm.com" , "Kapoor, Prasun" Date: Tue, 13 Nov 2018 17:37:44 +0100 Message-ID: <3021164.PQ0aESGyam@xps> In-Reply-To: <20181111074805.GA3496@jerin> References: <20181109163917.16845-1-honnappa.nagarahalli@arm.com> <20181110185534.5444-2-honnappa.nagarahalli@arm.com> <20181111074805.GA3496@jerin> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/1] hash: separate lf and rw lock lookup code paths X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 16:37:49 -0000 11/11/2018 08:48, Jerin Jacob: > > > > The lock-free algorithm has caused significant lookup > > performance regression for certain use cases. The > > regression is attributed to the use of non-relaxed > > memory orderings. 2 versions of the lookup functions > > are created. One that uses the RW lock and the one that > > is lock-free. This restores the performance regression > > caused for use cases that used RW lock version of the > > lookup function. > > > > Fixes: e605a1d36 ("hash: add lock-free r/w concurrency") > > Cc: honnappa.nagarahalli@arm.com > > > > Suggested-by: Jerin Jacob > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Ola Liljedahl > > Reviewed-by: Gavin Hu > > --- > > Acked-by: Jerin Jacob > Tested-by: Jerin Jacob Applied, thanks