From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E29A41B248 for ; Mon, 2 Oct 2017 18:52:43 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7C4C8205E1; Mon, 2 Oct 2017 12:52:43 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 02 Oct 2017 12:52:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=0ZvIhJUXjeZyqvg u95V4kQU+XI8u+lTarMtA37DodlY=; b=XYeQmVtbSz0hpIRdzwMQnZ2/H5BPeB5 zn2YGHjCDX2zF+KyZvr9V7Ql+Wfv1PgZWZ8lgrTunNjBXScCMXA5XOg1TFLkSNAm DqX3Xu8CrcDDQ1twHXuDgjwI9gI6FqqvSUUfkql+raDjvAa1d3FjOydzjdsHsPNn 1eQLNbn4n/0E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=0ZvIhJUXjeZyqvgu95V4kQU+XI8u+lTarMtA37DodlY=; b=QXxpeMwE Kd4k24CyeFee7TO/n6DoniIbnfSWlHjCD+fkpkIdLh3hK/MR6E8i50TSdV+E66VR mpJvjONDSJmh1f7w1gT/2Z9gJqezhrqwJQSBDcFP6WPXcLJ0C2ic/LNCvh+ZQW7l OAgBKiPRlNgWWEFz9UlBscEpqkV/QzJIhfW8vY0K2YuOzgr1WXASsr0OHsrd/GPW NKN0Qbs7+hEnH+Hac6BlJMHlPPFVIGnKYaQZwcwuzoIBtEsERuAJ0b1Ax//G+1tO mCDmMuj3l912Kq56sza6Vje0rDfKNG7J6N/Y7s5sBUfb7N70G9wUotryEb5UK3DJ z9MY8du50qqZuw== X-ME-Sender: X-Sasl-enc: 98THwU7+sn57kVq7VTW+wZct9r1Yni7AE8tUDPgCNA+w 1506963163 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2652D7FA60; Mon, 2 Oct 2017 12:52:43 -0400 (EDT) From: Thomas Monjalon To: "Hunt, David" Cc: dev@dpdk.org Date: Mon, 02 Oct 2017 18:52:42 +0200 Message-ID: <3021831.i70dt7xi5c@xps> In-Reply-To: <995cb4f2-44e0-9c4e-45ac-b97a2199a0f9@intel.com> References: <1506946848-173847-1-git-send-email-david.hunt@intel.com> <1917865.rASfWJCVJS@xps> <995cb4f2-44e0-9c4e-45ac-b97a2199a0f9@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] lib/power: add turbo functions to version.map X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Oct 2017 16:52:44 -0000 02/10/2017 18:25, Hunt, David: > Hi Thomas, > > > On 2/10/2017 4:39 PM, Thomas Monjalon wrote: > > 02/10/2017 17:06, Hunt, David: > >> On 2/10/2017 3:55 PM, Thomas Monjalon wrote: > >>> +DPDK_17.11 { > >>>> + global: > >>>> + > >>>> + rte_power_acpi_turbo_status; > >>> Is it really the function you want to expose? > >>> rte_power_turbo_status seems more generic. > >> Not really, it was in there for completeness, but users should be able > >> to keep track of the turbo'd cores, so not really needed. > >> > >>> More comments about what is part of the API: > >>> If you do not want to expose ACPI and VM implementations, > >>> it should not be part of the rte_* include files. > >> I'll address the above comments in the next version. > > > > You did not address the comment about what is rte_*.h. > > If you do not want to expose everything, you should move it to > > another .h file. > > > > Files starting with rte_ are included in doxygen API doc. > > Only rte_power.h is installed. > > The installed include, the doxygen doc and the map file > > should all expose the same API consistently. > > > > I think a cleanup is needed. > > While I agree a cleanup is needed, this small patch is only intended to > fix the priority issue of the shared library builds, which are broken at > the moment. > The initial patch should have had rte_power_turbo_status, not > rte_power_acpi_turbo_status. > Rather than moving code around at this stage, I propose having the three > exposed functions in the map file (with the correct names). OK, so we need a v3 (v2 has only 2 functions). > Then, later on, I can do an ABI breakage notification for the next > release to rename all the other rte*.h files, as some consumers of DPDK > may be using those directly, at which stage we will be down to just > exporting the functions in rte_power.h. > Does that sound OK with you? OK, thanks