From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 257481B5DF for ; Wed, 8 Nov 2017 01:53:56 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 709F020940; Tue, 7 Nov 2017 19:53:56 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 07 Nov 2017 19:53:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=tDyTLxilwGvibws+VnR/AFrKjw wyPckG+3DyXO2kBZI=; b=lThqkPLHCTvpszMcyxm7+AivElQ8H29MWgYBtDhQcG BuiIoFUOACDs8eRCJanPyq6CoD0gNtQTNILT2vcnHgMXTpk8Ha5LfuStaEdpvalR psq9RwtJ2+6FshoccTRpMwrZ/jgqR78EQvS4gyQdqs5UwnqUrt4VETmCvLCdb59l U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=tDyTLx ilwGvibws+VnR/AFrKjwwyPckG+3DyXO2kBZI=; b=GjP+fghOUPfnV7UvsQuMv/ g0Sgx0X4gUTCkY40xMguOdJRb7SHMO7Me/C8HjQzs5H/R0suxwmmz2UFe8nzFxAX a1lhq2iIR1vgy342Bx3GC8T1La3ohN1U3L90npRiZPEH5muNeRgLW7M9wUssyh+K 4j+LZCCAaDTew44j4AIIpbpwsg7CEtYOQnehEBRNVg9H9uwEmJ7mogXBv1D3JWyL u+pSbjKZtoQ873ZD1VZP+U1vQ0qcIBx66WNYL+fqe2H10l+fNTUjkyLfxOR6i7PK aQffCIQ5Rp4t6oik+rUZ+48FGGwvkL0ntwJcSPvaUszQ0kVozwiT30Ipr1uogR1g == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 30DBF24108; Tue, 7 Nov 2017 19:53:56 -0500 (EST) From: Thomas Monjalon To: Rasesh Mody Cc: dev@dpdk.org, Harish Patil , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com Date: Wed, 08 Nov 2017 01:53:55 +0100 Message-ID: <3022250.CEjPREgbVS@xps> In-Reply-To: <1510043665-8160-2-git-send-email-rasesh.mody@cavium.com> References: <1510043665-8160-1-git-send-email-rasesh.mody@cavium.com> <1510043665-8160-2-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/8] net/qede: fix to disable per-VF Tx switching feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2017 00:53:57 -0000 Hi, 07/11/2017 09:34, Rasesh Mody: > From: Harish Patil > > Provide a knob to control per-VF Tx switching feature by adding a config > option, CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH. By default, it will be kept > in disabled state for better performance with small sized frames. > > Fixes: 2ea6f76aff40 ("qede: add core driver") > Cc: stable@dpdk.org > > Signed-off-by: Harish Patil > --- > config/common_base | 1 + > drivers/net/qede/qede_ethdev.c | 9 ++++++++- > 2 files changed, 9 insertions(+), 1 deletion(-) > > --- a/config/common_base > +++ b/config/common_base > +CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=n We should remove all compile-time options because they cannot be used when DPDK is pre-packaged. That's why the rule is "NO NEW COMPILE TIME OPTION". After discussion with Ferruh, this patch is accepted as a hotfix. But this option is expected to be removed quickly. I've sent a patch to remove this option in 18.02: http://dpdk.org/ml/archives/dev/2017-November/081488.html It gives you some time to supersede my patch by introducing a run-time driver option. Thanks