From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 814ECA04A4; Tue, 26 May 2020 15:01:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C4C801D67B; Tue, 26 May 2020 15:01:20 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 2E9541D677 for ; Tue, 26 May 2020 15:01:19 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 9D9AA917; Tue, 26 May 2020 09:01:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 26 May 2020 09:01:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= DtHDQ9+V+OL6qgEDESf4gTKIvxJyY06dBbbR7EQtLwI=; b=a7PAXT/absnxYIGf ISmCBDtxd3atlGiKiv2CPSqAV5X7sEq8os6Ch2DHbX7O3TdTkDvKe33Ez47s23XL dmom9XzWMBdF778oShAXGYjt7Q+o+T3aCdCXQomD5FnUDlvOgDBdKs/QMydlhVRi adYX/eHFyQ5EMm64+FvXHAkcQsDC+cIcxisN8JOFCFbtYD7ILh8MiL3tQ+CCpJfn ydTYve2h7F7nou3Ro7LkXUpIEa4pvpko1t84pW4AK7/Id30NnVRjTRSaayZMjq3g bjqdEKNCieQ+WanZkCF/r2d4XFf0n18kWY5LZH47sysenDGRZrTuIUjXSIuFXu21 oDEtgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=DtHDQ9+V+OL6qgEDESf4gTKIvxJyY06dBbbR7EQtL wI=; b=kkjCdLeVUzYkoTYKDUiOrZ/o6WAj9jmlLwN0OoucA8qX9xjUwzlGtih+R 96Y9ndYsNC8MGDQRj6LGcfcFcCdROTJj7zRGFh+K+/bYuWV39aSN1t+e9iEXdZDt M2mvngG4PDUQYzwl6iCyqWcoS4c/D2GuLKtQ4Q5nD7ylKnrviMZFaGIl06fSR3XD jbd4cr7IEbbRxe+rqZO7wl4V/PeT824Ij4APNDoTcxPsI/OuMx+XlDjyAZHwXY5a cTfy2su/7d4LykvZzSc5xOxjiL2MZ4DgiXvZ8JwupU+A9N31AgRB7cPQV+hFVody B1yddbSVZnY9FCs216KeI1z7O0zyQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddvvddgheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B6BC330665B4; Tue, 26 May 2020 09:01:15 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: Ferruh Yigit , dev@dpdk.org, Neil Horman , John McNamara , Marko Kovacevic , dpdk-dev , David Marchand , Andrew Rybchenko Date: Tue, 26 May 2020 15:01:14 +0200 Message-ID: <3024961.L4zuKXn9mZ@thomas> In-Reply-To: References: <20200217153805.888130-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: plan splitting the ethdev ops struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/02/2020 06:07, Jerin Jacob: > On Mon, Feb 17, 2020 at 9:08 PM Ferruh Yigit wrote: > > > > For the ABI compatibility it is better to hide internal data structures > > from the application as much as possible. But because of some inline > > functions 'struct eth_dev_ops' can't be hidden completely. > > > > Plan is to split the 'struct eth_dev_ops' into two as ones used by > > inline functions and ones not used, and hide the second part that not > > used by inline functions completely to the application. > > It is a good improvement. IMO, If anything used in fast-path it > should be in ``struct rte_eth_dev`` > and rest can completely be moved to internal. In this case, if > `rte_eth_tx_descriptor_status` > not used on fastpath, Maybe we don't need to maintain the inline > status and move completely > to .c file. > > Those may be specifics of the work. In general, this change looks good to me. > > Acked-by: Jerin Jacob This ack is missing from v3. Jerin, please could you confirm on v3?