From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D40D41E21; Thu, 9 Mar 2023 21:16:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02763410EE; Thu, 9 Mar 2023 21:16:01 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 7663440695 for ; Thu, 9 Mar 2023 21:15:59 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 19C0A5C0108; Thu, 9 Mar 2023 15:15:59 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 09 Mar 2023 15:15:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1678392959; x=1678479359; bh=JWpR/QswaWsYj8BDynPcbWCh6qNbDopzsWF UnScycLs=; b=TDBh1X7Ixr82mYp46KEpfbvDbcQW9RhnR5pUNS/fwjN6BZgaOLo ur5ODO1cT5P/AMibX7bfzOA3x9TEZ+E4bug2IkhV2abUEom6Sg29kfxM2F7mgR8r ZQ3C5WaCtUww2RStUWi5sGrvIdWlfRR507WyW9JQu6hTv1RtJI7jYEHAZiZqk8X4 C4glMvkRQbhO2KEgAvT6iDA7e3N7KBvOG8QbK04mhbleGg+nRNqM0iA+f6zde89F Yjp55igBLdpv64Q4bmO57gnB8r6ewMspgpGxvhbvLCkC4d/ZS6F83bDIOU0SqGnz /e+un6QvHaxaCXtksel/eIihL3il7F1m2Lw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1678392959; x=1678479359; bh=JWpR/QswaWsYj8BDynPcbWCh6qNbDopzsWF UnScycLs=; b=iX428sS+AxbRhxZJhWW5MsU8jfhXyW2CkXcJz91adCIYV/tPR6C 0Te3wOh8H8eF8Gy6KbqWx5Q1gnx4RPQUhETVUeC82eFqB+GZfFkp7O/ephBpKaQV jFBABl0wrOi8C9++qSFDXcATmAknlyhveS1A1FlhXL7amVon6IpHrtDGMsdIpAvn wjVd2yp1RSFqbl2wVjLXpRGC+u7B0XHc6SOZ90FsNNenzYEcD5JX0S92GQ4Vw0+X z+DYiOi8l5kgiWKAIgem3yvNfXJMESUaZEms1QtI4dpViajdAvKHf5LlZ6a0xUbH fOoLM2l4ZFzYWCuccDepjPGgoniEG8K8soA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdduiedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Mar 2023 15:15:57 -0500 (EST) From: Thomas Monjalon To: Srikanth Yalavarthi Cc: dev@dpdk.org, sshankarnara@marvell.com, jerinj@marvell.com, aprabhu@marvell.com, ptakkar@marvell.com, pshukla@marvell.com Subject: Re: [PATCH v4 06/12] app/mldev: add test case to interleave inferences Date: Thu, 09 Mar 2023 21:15:56 +0100 Message-ID: <3025663.CbtlEUcBR6@thomas> In-Reply-To: <20230207154943.18779-7-syalavarthi@marvell.com> References: <20221129070746.20396-1-syalavarthi@marvell.com> <20230207154943.18779-1-syalavarthi@marvell.com> <20230207154943.18779-7-syalavarthi@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/02/2023 16:49, Srikanth Yalavarthi: > - ml_err("error_code = 0x%016lx, error_message = %s\n", error.errcode, > + ml_err("error_code = 0x%" PRIx64 ", error_message = %s\n", error.errcode, > error.message); > } > req = (struct ml_request *)op->user_ptr; > @@ -334,10 +334,10 @@ ml_request_initialize(struct rte_mempool *mp, void *opaque, void *obj, unsigned > RTE_SET_USED(mp); > RTE_SET_USED(obj_idx); > > - req->input = RTE_PTR_ADD( > - obj, RTE_ALIGN_CEIL(sizeof(struct ml_request), t->cmn.dev_info.min_align_size)); > - req->output = RTE_PTR_ADD(req->input, RTE_ALIGN_CEIL(t->model[t->fid].inp_qsize, > - t->cmn.dev_info.min_align_size)); > + req->input = (uint8_t *)obj + > + RTE_ALIGN_CEIL(sizeof(struct ml_request), t->cmn.dev_info.min_align_size); > + req->output = req->input + > + RTE_ALIGN_CEIL(t->model[t->fid].inp_qsize, t->cmn.dev_info.min_align_size); > req->niters = 0; > > /* quantize data */ > @@ -387,7 +387,7 @@ ml_inference_iomem_setup(struct ml_test *test, struct ml_options *opt, uint16_t > } > > t->model[fid].input = mz->addr; > - t->model[fid].output = RTE_PTR_ADD(t->model[fid].input, t->model[fid].inp_dsize); > + t->model[fid].output = t->model[fid].input + t->model[fid].inp_dsize; So you are fixing your previous patch in an unrelated patch? Really I cannot merge this mess in this state. Please provide cleaner patches in v5.