From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D239A04F0; Tue, 10 Dec 2019 13:27:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5AF301B13C; Tue, 10 Dec 2019 13:27:31 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E1D0437A2 for ; Tue, 10 Dec 2019 13:27:29 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2BC9222347; Tue, 10 Dec 2019 07:27:29 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 10 Dec 2019 07:27:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=laYbwZ9GVaTUcnQSq9lwZ2P/DjgXxyn8JzkwdWdok7Y=; b=lvyKWFhb80NI oC0MiJBjM+edGgtT02oQLRHoaTZQoFOH4iAj3wVTHi2Q4RC7y3APv3hNM2J3aOxM LfdSvpYuYtezIxNKvjyv5Uq5XtY7jpHgKzBxtK+25hHd/E4tIulVJxdqCsLke2i5 ZsfKuPUncjq6U2zOPTHOu0caVEP0Fm8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=laYbwZ9GVaTUcnQSq9lwZ2P/DjgXxyn8JzkwdWdok 7Y=; b=bUciFHhvT3gvI0SnRNlI1WJ6ARbRVkXbD9EQgwPgAJeR5OeyZNcTZdpeC Deiq4WJYT4wDo1YdtT/SFu2Aj6RlsGhWaPXx9QD5WmNJJL2Ma3I3iyoFTQmznEqV YqRJR0T7wMORBMgbZYUgqN0/r6t9B4/+m0NlV4bnJLW6PAfHorndiIBD/wgUV3CV sJFHaLgd2M4mW+mVHdUBS0WPd6Dl0v1V89C7nb4pEoOkWD3LIodlb74ZE0ak1Pf0 BYodggSvC+q79XBrxCDfCV70RoJJ36IT4Dj+pRXYAlqEKMB93VmE8zeC/gIvqDSW TC0GNFHp6FrA8IS4SFtZhh8yNE6Rw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudelfedggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D2A4730600A8; Tue, 10 Dec 2019 07:27:27 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson , robin.jarry@6wind.com Cc: John McNamara , Marko Kovacevic , dev@dpdk.org Date: Tue, 10 Dec 2019 13:27:26 +0100 Message-ID: <3025741.7YuKWOzX4Z@xps> In-Reply-To: <20191210120023.GA103@bricha3-MOBL.ger.corp.intel.com> References: <20191209210000.906000-1-thomas@monjalon.net> <20191210120023.GA103@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: fix build with python 3.8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/12/2019 13:00, Bruce Richardson: > On Mon, Dec 09, 2019 at 10:00:00PM +0100, Thomas Monjalon wrote: > > After upgrading to python-3.8.0, a syntax mismatch is revealed: > > > > doc/guides/conf.py:240: SyntaxWarning: "is not" with a literal. > > Did you mean "!="? > > if value is not '': > > > > Replacing "is not" with "!=" seems the right thing to do. > > > > Since this is basically just checking for an empty string is > "len(value) > 0" not more logical than either comparison against ''? Probably yes. I don't know what is the best practice in Python. Robin, any clue?