From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, maryam.tahhan@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app: fix proc_info app dependency
Date: Fri, 12 Jan 2018 16:41:41 +0100 [thread overview]
Message-ID: <3026438.BvA0BSuEar@xps> (raw)
In-Reply-To: <1c158e47-9425-7149-8251-bd2af3bff73f@intel.com>
12/01/2018 16:04, Burakov, Anatoly:
> On 12-Jan-18 2:59 PM, Thomas Monjalon wrote:
> > 12/01/2018 15:17, Anatoly Burakov:
> >> proc_info app is compiled unconditionally on Linux, but it's
> >> actually dependent on librte_ethdev library, which prevents
> >> DPDK from building without librte_ethdev library enabled.
> >>
> >> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
> >> Cc: maryam.tahhan@intel.com
> >> Cc: stable@dpdk.org
> >
> > nit: please insert a blank line here
> >
> >> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >> ---
> >> DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd
> >> -DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info
> >> +ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y)
> >> +DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += proc_info
> >> +endif
> >> DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump
> >
> > What about pdump and testpmd?
> >
> > I guess a lot of things do not compile without ethdev, isn't it?
> >
>
> True, however one can still disable testpmd compilation with a config
> option (CONFIG_RTE_TEST_PMD). I guess a better fix for this would be a
> new config option (i.e. CONFIG_RTE_PROC_INFO)?
Yes, good idea.
next prev parent reply other threads:[~2018-01-12 15:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 14:17 Anatoly Burakov
2018-01-12 14:59 ` Thomas Monjalon
2018-01-12 15:04 ` Burakov, Anatoly
2018-01-12 15:41 ` Thomas Monjalon [this message]
2018-01-12 17:49 ` [dpdk-dev] [PATCH v2] app/procinfo: add compilation option in config file Anatoly Burakov
2018-01-12 18:02 ` Thomas Monjalon
2018-01-12 18:05 ` Burakov, Anatoly
2018-01-12 18:27 ` [dpdk-dev] [PATCH v3] " Anatoly Burakov
2018-01-17 18:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3026438.BvA0BSuEar@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=maryam.tahhan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).