From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 6EF5E7D19; Wed, 13 Dec 2017 18:09:23 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F300A2088E; Wed, 13 Dec 2017 12:09:22 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 13 Dec 2017 12:09:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=jdaOlzvB1p/KzBANbFOs4GId6S pnX8yTYa+L007i2Kk=; b=BdEesHN40754/qfDUB9mpTX5e6iOs+WDN8jqlu3u56 R+y6hB60621+f884dCkuJlmVh1Qrj25IoWQEoXprhSD1B9RGEvVF8VmF9bi5mJNW RLNauQty5NNs/lIQulCKQyTBAKVTlrQL3bf0mcPSugHxK58x44oHgZ22WvhsXyT9 U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=jdaOlz vB1p/KzBANbFOs4GId6SpnX8yTYa+L007i2Kk=; b=T/TxxAVw/MwIIVT3D5piLy BV2Kb0z2vkavxT5hM1n2UWhebMwP7ie1hNnTVtqNxqSRjIoDSE6TM3Hgsl9Rnrze 4/OOq6uJNyw/9FbtR02nnaKmMhEwMFHwsvA+XKDNKfdGJ3CHKljf7s47up6GatZ4 5y3obVk4dassY/6QIsvn0iRPtLhe3Z5CMOha3xCC4chh8yebBXzKiAHA62MDXgrT yfOMTVqRUtxCMWSEEpTDvjUTIHUJN9cywGGfuuerMf4eS6/64YxbwmxVf3e6Em7x sy/L0W2MWgOpoRPc45jTzamehNS97BH9Sx5TZ8zyuLiDAZnifUp7iUtx3hYjip7w == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 991017E3D5; Wed, 13 Dec 2017 12:09:22 -0500 (EST) From: Thomas Monjalon To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet , Matan Azrad Cc: Adrien Mazarguil , dev@dpdk.org, stable@dpdk.org Date: Wed, 13 Dec 2017 18:09:21 +0100 Message-ID: <302650745.DN0YeEHu4l@xps> In-Reply-To: <20171213160916.e3rmxmhfhqz72wco@bidouze.vm.6wind.com> References: <1509637324-13525-1-git-send-email-matan@mellanox.com> <20171213160916.e3rmxmhfhqz72wco@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH v2 4/4] net/failsafe: fix removed device handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 17:09:23 -0000 13/12/2017 17:09, Ga=EBtan Rivet: > On Wed, Dec 13, 2017 at 03:48:46PM +0000, Matan Azrad wrote: > > From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com] > > > > Fixes: a46f8d5 ("net/failsafe: add fail-safe PMD") > > > > Fixes: b737a1e ("net/failsafe: support flow API") > > > > Cc: stable@dpdk.org > > > > > > >=20 > > > This patch is not a fix. > > > It relies on an eth_dev API evolution. Without this evolution, this p= atch is > > > meaningless and would break compilation if backported in stable branc= h. > > >=20 > >=20 > > It is a fix because the bug is finally solved by this patch. > > I agree that it cannot be backported itself, but maybe all the series s= hould be backported. > > Other idea: > > Add new patch which documents the bug and backport it. > > Remove it in this patch and remove cc stable from it. > > What do you think? > >=20 >=20 > I think you could write a crude version that would not rely on the > ethdev evolution (checking sdev->remove only), which would be incomplete > but still better than nothing. > And why not in this patch document the issue. > Without any dependency outside failsafe, this could be backported. >=20 > Then complete the fix with the API evolution if the new devops is > accepted. I think it is not worth the effort. It is a limitation in earlier releases and will be properly fixed with the new op. Please just remove the Cc:stable@dpdk.org.