From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id B78011BDA5;
Sun, 13 May 2018 23:45:57 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 3DC1E25A14;
Sun, 13 May 2018 17:45:57 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Sun, 13 May 2018 17:45:57 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=CpHHGCvZ1g0H3v8ddNp7GgCVBA
mT2qhJ3c87ENPB2bE=; b=oY6t4mTh+VaFfTYNaVhwyGOuw7h2s3g1I+MxuHKEeC
QJIfUyDiMIyyNJutKIew3pJIal0Rr7MANdQZec1AI52dE76Agg2srmWAYY97c6Rw
UymqY75i+e5rGl8hbj7Oc7wHRpnfRGXv3QAxxeSgkzbIshmf6PfYoIzmjU6C7Jj/
Q=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=CpHHGC
vZ1g0H3v8ddNp7GgCVBAmT2qhJ3c87ENPB2bE=; b=OroRLDn8GyLLnXYZUmsQ7S
0A7C3SVB3cDiq0inYfSesRkgtlsONe6ENcXWbCRnZ1WS7VwJ3CBQnx0xc6GTvfi2
TGcU7ieZv9hGTjGvNUNamBs/BTO/R9FHVx0j8nI553FlVTiThSWiMcV8YNeoUIAh
6Q5WBKTarFsvRMMR0noVFbcgd2KIXt72k5O8y/y3sK1NXnzOllneRmbxjeq/I+X9
RxbVHXoL2x8uS0m1jZM+A6SiaYQe9YjutnsXFZVkoMIqk0OJD7PMaxvEy5JOk4H+
Zd67rw2m7wEl8Y5ChznsaNSJ6WYMZ3BsPhEiBU4vLXoFj2/DFl0pAivPDSK/hm9Q
==
X-ME-Sender: <xms:FbL4WmkMdiPv-7fLxT39WOENs1HtJzUGcQUXDuvWHZR_U0I0dEg3mw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id A23F4E4443;
Sun, 13 May 2018 17:45:56 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Reshma Pattan <reshma.pattan@intel.com>
Cc: stable@dpdk.org, dev@dpdk.org
Date: Sun, 13 May 2018 23:45:55 +0200
Message-ID: <3027624.dysL5kJjZl@xps>
In-Reply-To: <1525865729-16086-2-git-send-email-reshma.pattan@intel.com>
References: <1525865729-16086-1-git-send-email-reshma.pattan@intel.com>
<1525865729-16086-2-git-send-email-reshma.pattan@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/quota_watermark: fix
gcc 8.0.1 cast between incompatible types
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 13 May 2018 21:45:58 -0000
09/05/2018 13:35, Reshma Pattan:
> Gcc 8.0.1 reports incompatible cast between types i.e. from
> `void (*)(void *)` to `(int (*)(void *)`.
>
> Change the pipeline_stage prototype to retun int type
> to fix the issue.
>
> Fixes: a0ffcb257a ("examples/quota_watermark: correct code indentation")
> CC: stable@dpdk.org
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> /* typecast is a workaround for GCC 4.3 bug */
> - rte_eal_remote_launch((int (*)(void *))pipeline_stage,
> + rte_eal_remote_launch(pipeline_stage,
> NULL, lcore_id);
The comment can be removed.
Applied with above fixed, thanks