From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3BFA44F96 for ; Mon, 12 Mar 2018 16:08:49 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2018 08:08:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,461,1515484800"; d="scan'208";a="23942954" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.62]) ([10.237.221.62]) by orsmga007.jf.intel.com with ESMTP; 12 Mar 2018 08:08:47 -0700 To: Vipin Varghese , dev@dpdk.org, pascal.mazon@6wind.com References: <1518446689-26839-1-git-send-email-vipin.varghese@intel.com> <1520886094-28319-1-git-send-email-vipin.varghese@intel.com> From: Ferruh Yigit Message-ID: <302ea231-499e-f3b2-2963-34cc8507e21a@intel.com> Date: Mon, 12 Mar 2018 15:08:46 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1520886094-28319-1-git-send-email-vipin.varghese@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/tap: allow user MAC to be passed as args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Mar 2018 15:08:49 -0000 On 3/12/2018 8:21 PM, Vipin Varghese wrote: > @@ -1591,7 +1632,7 @@ enum ioctl_mode { > int speed; > char tap_name[RTE_ETH_NAME_MAX_LEN]; > char remote_iface[RTE_ETH_NAME_MAX_LEN]; > - int fixed_mac_type = 0; > + struct ether_addr user_mac = { .addr_bytes = {0, 0, 0, 0, 0, 0} }; A single '0' will do the job J struct ether_addr user_mac = { .addr_bytes = {0} }; Would you mind sending a new version?