From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DE2334596C;
	Thu, 12 Sep 2024 11:05:48 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C613B40E5A;
	Thu, 12 Sep 2024 11:05:48 +0200 (CEST)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id EC702406BA
 for <dev@dpdk.org>; Thu, 12 Sep 2024 11:05:45 +0200 (CEST)
Received: from mail.maildlp.com (unknown [172.19.88.105])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4X4BM8479czyQv4;
 Thu, 12 Sep 2024 17:04:04 +0800 (CST)
Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10])
 by mail.maildlp.com (Postfix) with ESMTPS id AB70E140361;
 Thu, 12 Sep 2024 17:05:12 +0800 (CST)
Received: from [10.67.121.161] (10.67.121.161) by
 dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2507.39; Thu, 12 Sep 2024 17:05:12 +0800
Message-ID: <302ed2ef-7210-419c-9a30-4386c8730a89@huawei.com>
Date: Thu, 12 Sep 2024 17:05:12 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] app/testpmd: add support for setting device EEPROM
To: Chaoyong He <chaoyong.he@corigine.com>, <dev@dpdk.org>
CC: <oss-drivers@corigine.com>, James Hershaw <james.hershaw@corigine.com>,
 <ferruh.yigit@amd.com>
References: <20240912061030.2834034-1-chaoyong.he@corigine.com>
 <20240912065459.2858959-1-chaoyong.he@corigine.com>
 <20240912065459.2858959-2-chaoyong.he@corigine.com>
Content-Language: en-US
From: fengchengwen <fengchengwen@huawei.com>
In-Reply-To: <20240912065459.2858959-2-chaoyong.he@corigine.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.121.161]
X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To
 dggpeml500024.china.huawei.com (7.185.36.10)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2024/9/12 14:54, Chaoyong He wrote:
> From: James Hershaw <james.hershaw@corigine.com>
> 
> There is currently no means to test the .set_eeprom function callback of
> a given PMD in drivers/net/. This patch adds functionality to allow a
> user to set device eeprom from the testpmd cmdline.
> 
> usage:
>   testpmd> set port <port-id> eeprom magic <magic> value <value>
>   offset <offset>

this should be a high risk command (it will modify the eeprom of NIC), if use mis-use may lead to serious problem.

if add it, I suggest add acknowledgement from user.