From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 02E9D1B83B
for <dev@dpdk.org>; Wed, 31 Jan 2018 21:37:43 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id A109020B44;
Wed, 31 Jan 2018 15:37:43 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
by compute1.internal (MEProxy); Wed, 31 Jan 2018 15:37:43 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=t9p842RnjHg8O6auK6VEXvWh2/
pVmO5E5Ga6KSgl15w=; b=QvlSQYWG6bsAKLTwonPvcprL+csRNRIqktPjiwRwB5
NxXiVt20Pq3WAVjZZkiFK7wbaeHVqmBsjfjQ1F7dZBqAZjc7bWN9BfPUUM+/DgyF
dLRjqdB7qiyZTHzat8l2DM51IpUQ4a00P+BLDIz67kQvnZBujjIDaS189obnrLN2
o=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=t9p842
RnjHg8O6auK6VEXvWh2/pVmO5E5Ga6KSgl15w=; b=UrMT95c3YlVXNpMWtqo6lr
+1wyGRi8Vi7f5EKhogcr2G0Or8K6GAD9Q7vczcRZd5VT4a2RRhRyV+h+32pVgrIo
Y4ZWLFmhNmrPq3zPT0uxR44EYatmX1pEFfPtTk18aOv+f8G78Y50o3lUtoEjvvRS
8Xc/62a7fpifjWFnlJ99EZM4kMGIMtVv84CXS/Z7Ur+nkoOOCmc5VZs1H15QwlCt
sCPLeTe0pNKLhwzBDsn8lyLCJIDapeZXwopB0OJslJDioMXoHG/Xh+lIMKSf4pkv
/CViAs4sioIjEbOEqcILiLIPGvYrMcTU4Ac8B1K25uRdWH1KDU1PHAlqBIoet0EQ
==
X-ME-Sender: <xms:FylyWh4hU-n-zk18ss4O9BcHfIn_KXXBwvUxK4o36N-alEBVR9o85g>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 52D5D7E664;
Wed, 31 Jan 2018 15:37:43 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Matan Azrad <matan@mellanox.com>
Cc: dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>
Date: Wed, 31 Jan 2018 21:36:55 +0100
Message-ID: <3030595.E4uSP6LIab@xps>
In-Reply-To: <1517321620-14198-2-git-send-email-matan@mellanox.com>
References: <1517321620-14198-1-git-send-email-matan@mellanox.com>
<1517321620-14198-2-git-send-email-matan@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix invalid port detach
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Jan 2018 20:37:44 -0000
30/01/2018 15:13, Matan Azrad:
> Using registration to all ports includes also the ports which should not
> be used by the application.
>
> It is nice to print each port event by testpmd but in case of RMV
> event, testpmd tries to detach the port and this case is problematic
> when the port should not be used by the application.
>
> Check the port validation before detach API calling.
>
> Fixes: 4fb82244b394 ("app/testpmd: extend event printing")
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
Series applied, thanks