* [dpdk-dev] [PATCH] crypto/mlx5: fix driver probing error flow
@ 2021-07-29 6:50 Michael Baum
2021-07-30 19:23 ` [dpdk-dev] [EXT] " Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Michael Baum @ 2021-07-29 6:50 UTC (permalink / raw)
To: dev; +Cc: Matan Azrad, stable
In crypto driver probing, there are two validations after context
allocation.
When one of them fails, the context structure was not freed what caused
a memory leak.
Free it.
Fixes: debb27ea3442 ("crypto/mlx5: create login object using DevX")
Fixes: e8db4413cba5 ("crypto/mlx5: add keytag configuration")
Cc: stable@dpdk.org
Signed-off-by: Michael Baum <michaelba@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
drivers/crypto/mlx5/mlx5_crypto.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c
index ea734f4d5c..b3d5200ca3 100644
--- a/drivers/crypto/mlx5/mlx5_crypto.c
+++ b/drivers/crypto/mlx5/mlx5_crypto.c
@@ -1021,12 +1021,14 @@ mlx5_crypto_dev_probe(struct rte_device *dev)
ret = mlx5_crypto_parse_devargs(dev->devargs, &devarg_prms);
if (ret) {
DRV_LOG(ERR, "Failed to parse devargs.");
+ claim_zero(mlx5_glue->close_device(ctx));
return -rte_errno;
}
login = mlx5_devx_cmd_create_crypto_login_obj(ctx,
&devarg_prms.login_attr);
if (login == NULL) {
DRV_LOG(ERR, "Failed to configure login.");
+ claim_zero(mlx5_glue->close_device(ctx));
return -rte_errno;
}
crypto_dev = rte_cryptodev_pmd_create(ibv->name, dev,
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [EXT] [PATCH] crypto/mlx5: fix driver probing error flow
2021-07-29 6:50 [dpdk-dev] [PATCH] crypto/mlx5: fix driver probing error flow Michael Baum
@ 2021-07-30 19:23 ` Akhil Goyal
2021-07-31 9:37 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Akhil Goyal @ 2021-07-30 19:23 UTC (permalink / raw)
To: Michael Baum, dev, Thomas Monjalon; +Cc: Matan Azrad, stable
> In crypto driver probing, there are two validations after context
> allocation.
>
> When one of them fails, the context structure was not freed what caused
> a memory leak.
>
> Free it.
>
> Fixes: debb27ea3442 ("crypto/mlx5: create login object using DevX")
> Fixes: e8db4413cba5 ("crypto/mlx5: add keytag configuration")
> Cc: stable@dpdk.org
>
> Signed-off-by: Michael Baum <michaelba@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
Applied to dpdk-next-crypto
@Thomas Monjalon: I do not think title and patch description are inline.
You may fix it while pulling on main branch.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [EXT] [PATCH] crypto/mlx5: fix driver probing error flow
2021-07-30 19:23 ` [dpdk-dev] [EXT] " Akhil Goyal
@ 2021-07-31 9:37 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-07-31 9:37 UTC (permalink / raw)
To: Michael Baum, Matan Azrad, Akhil Goyal; +Cc: dev, stable
30/07/2021 21:23, Akhil Goyal:
> > In crypto driver probing, there are two validations after context
> > allocation.
> >
> > When one of them fails, the context structure was not freed what caused
> > a memory leak.
> >
> > Free it.
> >
> > Fixes: debb27ea3442 ("crypto/mlx5: create login object using DevX")
> > Fixes: e8db4413cba5 ("crypto/mlx5: add keytag configuration")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Michael Baum <michaelba@nvidia.com>
> > Acked-by: Matan Azrad <matan@nvidia.com>
> > ---
> Applied to dpdk-next-crypto
> @Thomas Monjalon: I do not think title and patch description are inline.
> You may fix it while pulling on main branch.
New title:
crypto/mlx5: fix leaks on probing failure
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-31 9:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-29 6:50 [dpdk-dev] [PATCH] crypto/mlx5: fix driver probing error flow Michael Baum
2021-07-30 19:23 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-31 9:37 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).