From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CECCF4590C; Thu, 5 Sep 2024 11:50:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BEFAA40264; Thu, 5 Sep 2024 11:50:19 +0200 (CEST) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by mails.dpdk.org (Postfix) with ESMTP id 3C83540264 for ; Thu, 5 Sep 2024 11:50:18 +0200 (CEST) Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a8a6d1766a7so54062266b.3 for ; Thu, 05 Sep 2024 02:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1725529818; x=1726134618; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pTbisn0kzC2+iBQASooozg9R5Kx7r8COs2tws63Z6tQ=; b=DlNX2kGmmFnW5bFM7U6lpGG703gFLZiV30E/Hth8Rv+j5qY418MpQJYWp3i9xAkefJ Fz4lbREOkxwsI8fykhomOckv11Dxy498Wz+Nb59oXfW1Ry9W2tYqjUJN81medSSmAsKO 5ngRpVAjvgpFR7OEq0NopdpuSW7fiYLwjcHeRjJPimBVVQT9+o1NSC0luBIBEpTt9dc2 hGbtSdz5+gZ2orvntWGetCOPP/pT57jHiIElNAngmUrgoMT6qCVwTwqPdaYbijyXy478 ZrwJX7Spey9g9RYul2WNav+pVWONDOGddXriLm00b3c8y1HzS+pRGy+Ovj+cpbAlIKCw Q01w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725529818; x=1726134618; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pTbisn0kzC2+iBQASooozg9R5Kx7r8COs2tws63Z6tQ=; b=af6aYU4yq5W/EbFQ0gkf2hIFhJaKzOjBCnSx7yWXi464inehJr21jtErc3i+x0YbMp BkT5l43hWiPUVLaeO+CHkYwOc2JqGc63wRofXdEVMp9DTvcT+/G53JiNLjPQgGQgMjh0 wdOatcm/CCifuUJnz5vKMIdF5dic5+rbBkqNQgluoMXbtma1xHjECvj9HipdNsbn4z6j WS8o9avxffkGCXqxd6GrYuiPA2Y6++5yT4ylpyxYd126OYUxqu/gNq4ZFwcbH3VFVsS7 ITvRw/DuICKNO2OJlkRge1lDGAJ6MlJDnR6CxCvknK2JuQZ7l/ROl8s+A1+ne4aZhBny gAAA== X-Forwarded-Encrypted: i=1; AJvYcCX9IFcOcJ3BGgNsm/kpESkC8mWy7LW50poB0TRX+1jggs7Fy2Y9VU8ydSFfFT1Q7jFYI7M=@dpdk.org X-Gm-Message-State: AOJu0YyA5FArX1eMNx73aDriNJZtoIjDOhT1EjxSlIvxjWWA0yJM/74S eMaKH6IXU2cHprGFlpYv3A4X8PJYwYAA6f39Pl3cKnrELy57+qwDBrH6Gr52SDs= X-Google-Smtp-Source: AGHT+IHdT7OfLgOQPylbFJ49As5akhEY5OoZ6fVNYJgWdZqRpALfQqogGdy3FXWcMP6hlLG7e4d6qA== X-Received: by 2002:a17:907:3da7:b0:a8a:7897:c043 with SMTP id a640c23a62f3a-a8a7897ca76mr43806466b.43.1725529817617; Thu, 05 Sep 2024 02:50:17 -0700 (PDT) Received: from [192.168.200.22] ([84.245.121.62]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8a623a6c80sm114151166b.174.2024.09.05.02.50.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Sep 2024 02:50:17 -0700 (PDT) Message-ID: <303c71e1-bac3-4af7-aa16-36b2c34ae000@pantheon.tech> Date: Thu, 5 Sep 2024 11:50:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 06/12] dst: add basic capability support To: Jeremy Spewock Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, npratte@iol.unh.edu, dmarx@iol.unh.edu, alex.chapman@arm.com, dev@dpdk.org References: <20240301155416.96960-1-juraj.linkes@pantheon.tech> <20240821145315.97974-1-juraj.linkes@pantheon.tech> <20240821145315.97974-7-juraj.linkes@pantheon.tech> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 26. 8. 2024 18:56, Jeremy Spewock wrote: > Just one comment about adding something to a doc-string, otherwise > looks good to me: > > Reviewed-by: Jeremy Spewock > > On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš > wrote: > >> diff --git a/dts/framework/test_result.py b/dts/framework/test_result.py >> index 306b100bc6..b4b58ef348 100644 >> --- a/dts/framework/test_result.py >> +++ b/dts/framework/test_result.py >> @@ -25,10 +25,12 @@ >> >> import os.path >> from collections.abc import MutableSequence >> -from dataclasses import dataclass >> +from dataclasses import dataclass, field >> from enum import Enum, auto >> from typing import Union >> >> +from framework.testbed_model.capability import Capability >> + >> from .config import ( >> OS, >> Architecture, >> @@ -63,6 +65,12 @@ class is to hold a subset of test cases (which could be all test cases) because >> >> test_suite_class: type[TestSuite] >> test_cases: list[type[TestCase]] >> + required_capabilities: set[Capability] = field(default_factory=set, init=False) > > This should probably be added to the Attributes section of the > doc-string for the class. Ah, I missed this, thanks. > When it's there, it might also be useful to > explain that this is used by the runner to determine what capabilities > need to be searched for to mark the suite for being skipped. And also test cases. > The only > reason I think that would be useful is it helps differentiate this > list of capabilities from the list of required capabilities that every > test suite and test case has. > I want to add this: The combined required capabilities of both the test suite and the subset of test cases. I think this makes it clear that it's different from the individual required capabilities of test suites and cases. Let me know what you think. >> + >> + def __post_init__(self): >> + """Gather the required capabilities of the test suite and all test cases.""" >> + for test_object in [self.test_suite_class] + self.test_cases: >> + self.required_capabilities.update(test_object.required_capabilities) > >>