From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7653AA09D9; Wed, 11 Nov 2020 16:02:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B2252137D; Wed, 11 Nov 2020 16:02:19 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id B9E0FA3 for ; Wed, 11 Nov 2020 16:02:17 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 544B65C0105; Wed, 11 Nov 2020 10:02:14 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 11 Nov 2020 10:02:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= Zx7yGncl/yOjUzSA0upmHELyaEyXWJC33XA+uq9jn8w=; b=mUwotPNoes44t8mv bNWakw+hgAIpp2BxKVlf72pHcDSXYYiP2IYU5B1vlH5HalBpmMBpU7mgWD0OeXMU aok+2zuMycTw/0iF2cyYl4rNK9qHCryRXzuR8Rl8T/kZUNv9Cz+82BZ8z9NtwWsA 8SBfrvuJmMAwBNumEDXuQsbvWUxIO7/G8CAs/FcP/lF1JXjpTXIMhVdqVDBgaTpG btfPXw7gISQfg/aOgjlbuPAg1ks1PcZgrlfXhGBwArLsPt0IIbJ5lLa9XC/FtOTJ T5lD5zfp5grw3RBtepYAnFq1eIYpAGUICnnMJS735IztChNlqS+aME0ejTx+kVa2 ZqpShw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Zx7yGncl/yOjUzSA0upmHELyaEyXWJC33XA+uq9jn 8w=; b=Yde5UnX6HTqEzR6kRtsAZT/Nzp1dBb1gp9hyGRwrQ7AMvqudATjZBfPiK 6Sf/EkZsz5GB0SVWTPO3EgW5o9MWom3VOveIVH64d2rxjRkJV2G09i1cnZC2UFt/ MdoDj+B8ztnJwkXqJ6Bx64Dqgmtg2rHA9wVrRRcmeATfES14MLr2wzwLvNmemo5V ww3uZxvrDGhr+k8BAlDtDn58tx5qb2IdYoX63yx+nSJx89Ao4v2s5EVrnT9x2FPb 82dwwsWKVWc6Y9e6BvA0ieHJjh6FWDGAuiuN31nOdYCnYdA1rAi3b0xxd/92J2IF zvBcoL/Nh+IdFEvMGzfYYTYLeS0HQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddvtddguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepleeuledvgeehvdekvdetffetudevkefhleffhfetleevgeeiffek teffleeffeegnecuffhomhgrihhnpehmihgtrhhoshhofhhtrdgtohhmnecukfhppeejje drudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 07BB83280064; Wed, 11 Nov 2020 10:02:12 -0500 (EST) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Luca Boccassi , Narcisa Ana Maria Vasile , John Alexander Date: Wed, 11 Nov 2020 16:02:10 +0100 Message-ID: <3042169.36grohAEOo@thomas> In-Reply-To: <20201029225505.30093-1-dmitry.kozliuk@gmail.com> References: <20201029225505.30093-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/10/2020 23:55, Dmitry Kozlyuk: > MSBuild XML files have to use CRLF line-endings, otherwise any change > results in the whole file being rewritten with CRLF line-endings by > Visual Studio. However, it's inconvenient to have such files checked-out > with CLRF in Unix environments. > > Add suggested git configuration to top-level README, so that Unix > developers don't miss it. Remove .gitattributes, because core.autocrlf > overrides eol= attribute. Convert line-endings of the existing files in > the repository. It is converted to what? You mean all files should have LF endings in the repo? [...] > windows/virt2phys/virt2phys.sln | 54 ++-- > windows/virt2phys/virt2phys.vcxproj | 454 ++++++++++++++-------------- > 4 files changed, 259 insertions(+), 258 deletions(-) The file windows/virt2phys/virt2phys.vcxproj.filters is not converted. And I see other stuff to fix, see below. > +Some Windows files use have to use CRLF line-endings. "use have to use" -> "have to use" ? Isn't it automatic to have CRLF on Windows git working tree? > +Unix developers can configure git to get only LF on checkout: > + > + git config core.autocrlf input Isn't it the default? If all files have LF, there is nothing to do on Unix. I think more fixes are required as below: --- a/windows/netuio/netuio.sln +++ b/windows/netuio/netuio.sln @@ -1,4 +1,3 @@ - Microsoft Visual Studio Solution File, Format Version 12.00 # Visual Studio 14 VisualStudioVersion = 14.0.25420.1 diff --git a/windows/netuio/netuio.vcxproj b/windows/netuio/netuio.vcxproj index 87c8b94..f01bf2a 100644 --- a/windows/netuio/netuio.vcxproj +++ b/windows/netuio/netuio.vcxproj @@ -1,4 +1,4 @@ - + @@ -110,4 +110,4 @@ - \ No newline at end of file + diff --git a/windows/netuio/netuio.vcxproj.filters b/windows/netuio/netuio.vcxproj.filters index 49c1da1..43536ce 100644 --- a/windows/netuio/netuio.vcxproj.filters +++ b/windows/netuio/netuio.vcxproj.filters @@ -1,4 +1,4 @@ - + @@ -51,4 +51,4 @@ Source Files - \ No newline at end of file + diff --git a/windows/virt2phys/virt2phys.sln b/windows/virt2phys/virt2phys.sln index ea4eec4..02dc38d 100644 --- a/windows/virt2phys/virt2phys.sln +++ b/windows/virt2phys/virt2phys.sln @@ -1,4 +1,3 @@ - Microsoft Visual Studio Solution File, Format Version 12.00 # Visual Studio Version 16 VisualStudioVersion = 16.0.29613.14 diff --git a/windows/virt2phys/virt2phys.vcxproj b/windows/virt2phys/virt2phys.vcxproj index 69af150..c86cc9b 100644 --- a/windows/virt2phys/virt2phys.vcxproj +++ b/windows/virt2phys/virt2phys.vcxproj @@ -1,4 +1,4 @@ - + @@ -225,4 +225,4 @@ - \ No newline at end of file +