From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52B3C42D72; Tue, 27 Jun 2023 15:07:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB74540F18; Tue, 27 Jun 2023 15:07:27 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 4373840EE1 for ; Tue, 27 Jun 2023 15:07:26 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C130A5C00EC; Tue, 27 Jun 2023 09:07:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 27 Jun 2023 09:07:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687871243; x=1687957643; bh=zpsV9CPGWSyJGZvJAz/6Ib/fEpC8Bk/+uzS wwTDieGY=; b=DUMKRq4FRcOzMuJikVuyjhx4z24MtV0gRHlnyJbK3Rel5KuVuyg SjwTwT7+WD015g5Px/vFZ2eHBipHC5UV4hYBHyIbqHBzDkBbTipY9KDpzA427yly jNoVFZ9U9TBd2upv5OcZL0tXfuUFMdX0QvPDUXYFjQLAXST34wwaKdn/qSh5wCx/ Keo76Mc+27h4r77PcyHy16Ka91fYUrylb/OaP+pTCHkVlIVkmPX7V2POHl8yVWTW Q4i2KRWC92ZJuWLyMlf46mFNG8n/fT1iFoaR1hOhVsrWivXcTi9rpGAKkJ/Z0C2s f3EoB0Oyfhj163eVtkzkNpCz8mHM+q2BhEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687871243; x=1687957643; bh=zpsV9CPGWSyJGZvJAz/6Ib/fEpC8Bk/+uzS wwTDieGY=; b=G49GsdijObxGtzRYxRBhJZs9OV+9hJNWJWPhiKYGnkORJ9fNwlT UQ3b7kckyYsmQ53sVycEpaiMxFMx+mF6QGeNUY4jNaybHFQI+TUdxlZOrW/jMR0Q b1+xDqnPFpFmrBQkcUn2bEc44I3MpwM42pW8Ea/VqoNlWOfVkBJZ2uWiwjQRokgm YTg1++Zq4MHo92uA6XqWg6/496GU/7x/G6MW2xcyCVAGNc6prPfpMASHZ7m/9N/P RD2X7c2G6G0kXcW6Qty7PJl3gpgHmy+Zi/aSl17ec5CZtVU5iAlIeUOKyZL5lTyw XSV9AaQxk+IPdTckK4KM2Z9aPwhjfyoujfw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrtddtgddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfeehueeugfetkeeftedvhfevffdvveefkedvffeuffevfffhudet tedtvdehueehnecuffhomhgrihhnpehmvghsohhnsghuihhlugdrtghomhenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhho nhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Jun 2023 09:07:22 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Tyler Retzlaff Subject: Re: [PATCH] buildtools: remove assumption about current work dir Date: Tue, 27 Jun 2023 15:07:20 +0200 Message-ID: <3042910.ktpJ11cQ8Q@thomas> In-Reply-To: <20230615202446.GC32486@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230614144728.481566-1-bruce.richardson@intel.com> <20230615202446.GC32486@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/06/2023 22:24, Tyler Retzlaff: > On Wed, Jun 14, 2023 at 03:47:28PM +0100, Bruce Richardson wrote: > > According to meson documentation, we should not make any assumptions as > > to what directory a script is called from[1]. The use of "relpath" when > > processing the output of directory globbing is therefore unsafe, as it > > was stripping off paths relative to the current directory - which just > > happened to be the same as the root directory we were processing. > > > > To improve safety, and support meson clones (like muon) which > > don't always run things from the currently processed path, we need to > > explicitly specify that the start parameter for relpath() should be > > "root" value. > > > > [1] https://mesonbuild.com/Reference-manual_functions.html#run_command > > > > Signed-off-by: Bruce Richardson > > --- > Reviewed-by: Tyler Retzlaff Applied, thanks.