From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E6B845683 for ; Mon, 13 Jul 2015 14:14:49 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 13 Jul 2015 05:14:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,462,1432623600"; d="scan'208";a="727897109" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga001.jf.intel.com with ESMTP; 13 Jul 2015 05:14:48 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS) id 14.3.224.2; Mon, 13 Jul 2015 13:14:41 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.117]) by irsmsx111.ger.corp.intel.com ([169.254.2.232]) with mapi id 14.03.0224.002; Mon, 13 Jul 2015 13:14:41 +0100 From: "Kulasek, TomaszX" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v3 0/8] Dynamic RSS Configuration for Bonding Thread-Index: AQHQsnsvBDF2LLl1CEWkguq8fLHSYJ3GVRaAgBLsP4CAAAQngIAAHL/Q Date: Mon, 13 Jul 2015 12:14:41 +0000 Message-ID: <3042915272161B4EB253DA4D77EB373A019FE8E3@IRSMSX102.ger.corp.intel.com> References: <1434723200-7528-1-git-send-email-tomaszx.kulasek@intel.com> <5593BB53.2060204@intel.com> <1604538.YavAJG9xMg@xps13> <2027479.0yqGHXrX1o@xps13> In-Reply-To: <2027479.0yqGHXrX1o@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 0/8] Dynamic RSS Configuration for Bonding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2015 12:14:50 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, July 13, 2015 13:18 > To: Kulasek, TomaszX > Cc: dev@dpdk.org; Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH v3 0/8] Dynamic RSS Configuration for > Bonding >=20 > 2015-07-13 13:03, Thomas Monjalon: > > 2015-07-01 11:05, Declan Doherty: > > > On 29/06/15 15:50, Tomasz Kulasek wrote: > > > > OVERVIEW > > > > -------- > > > > 1) Setting .rxmode.mq_mode for bonding device to ETH_MQ_RX_RSS > > > > makes bonding device fully RSS-capable, so all slaves are > synchronized with its configuration. > > > > This mode is intended to provide RSS configuration as known from > > > > "dynamic RSS configuration for one port" and made slaves > > > > transparent for client application implementation. > > > > > > > > 2) If .rxmode.mq_mode for bonding device isn't ETH_MQ_RX_RSS, > > > > slaves are not synchronized. That provides an ability to configure > > > > them manually. This mode may be useful when application wants to > > > > manage RSS in an unusual way and the consistency of RSS > configuration for slaves isn't required. > > > > > > > > Turning on/off RSS mode for slaves when bonding is started is not > possible. > > > > Other RSS configuration is propagated over slaves, when bonding > > > > device API is used to do it. > > > > > > > > v3 changes: > > > > - checkpatch cleanups > > > ... > > > > > > Acked-by : Declan Doherty > > > > Applied without patches 5 and 6: >=20 > Sorry, after more review, this series won't be pushed at all. > There is an obvious error in patch 4, and patch 2/3 must be discussed. What's wrong with patches 2/3? Some details? >=20 > > - As discussed earlier, patch 5 workaround a missing flag to announce > > stats per queue availability. > > > > - Patch 6 introduce a new dependency (ncurses) to build a new bond_rss > example. > > Examples are useful to show how to use some features. Maybe you can > > show bonding RSS in the existing bonding example without adding bells > and whistles. > > The example directory must be kept reasonnably maintainable. >=20 Ok. I understand that. This application was created to help me in developme= nt process and using ncurses made it a lot easier. The intention wasn't "ad= ding bells and whistles" but made it usable in dynamic environment.