From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A1468592A for ; Mon, 13 Jul 2015 16:43:55 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 13 Jul 2015 07:43:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,463,1432623600"; d="scan'208";a="523468077" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by FMSMGA003.fm.intel.com with ESMTP; 13 Jul 2015 07:43:54 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.117]) by IRSMSX154.ger.corp.intel.com ([169.254.12.91]) with mapi id 14.03.0224.002; Mon, 13 Jul 2015 15:43:26 +0100 From: "Kulasek, TomaszX" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v3 2/8] ring: dynamic rss configuration Thread-Index: AQHQsntwp5xK7vx5eEaPH+xFmMQ+2Z3ZW0mAgAAz/2A= Date: Mon, 13 Jul 2015 14:43:25 +0000 Message-ID: <3042915272161B4EB253DA4D77EB373A019FE98C@IRSMSX102.ger.corp.intel.com> References: <1434723200-7528-1-git-send-email-tomaszx.kulasek@intel.com> <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com> <1435589444-1988-3-git-send-email-tomaszx.kulasek@intel.com> <2033219.3PlE3JM2PJ@xps13> In-Reply-To: <2033219.3PlE3JM2PJ@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 2/8] ring: dynamic rss configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2015 14:43:56 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, July 13, 2015 14:36 > To: Kulasek, TomaszX > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/8] ring: dynamic rss configuration >=20 > 2015-06-29 16:50, Tomasz Kulasek: > > This implementation allows to set and read RSS configuration for ring > > device, and is used to validate right values propagation over the > > slaves, in test units for dynamic RSS configuration for bonding. > > > > It have no impact on packet processing by ring device. >=20 > Adding some fake RSS to the ring PMD (in order to test bonding) is weird. > The ring PMD is not a driver for testing. Maybe that the null PMD would b= e > more appropriate. > By the way the current RSS implementation is really bound to Intel > devices. > Before applying it to more drivers, we have to make sure it is generic > enough. Maybe the RETA needs more abstraction. This is not RSS implementation, but implementation of Dynamic RSS Configura= tion, already existing, and well defined in official documentation for sing= le port. I don't know where you see bounding to Intel device. It's an implementation= of official API. Anyway I will appreciate for any comment and opinion on that and clarificat= ion what means more RETA abstraction in context of official API. I will check the possibility of moving it to the null pmd driver and will p= repare new version for easier reviewing. Meantime I'm waiting for more opin= ions.