From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomaszx.kulasek@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id F18015683
 for <dev@dpdk.org>; Tue, 29 Sep 2015 13:29:28 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga101.jf.intel.com with ESMTP; 29 Sep 2015 04:29:28 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,607,1437462000"; d="scan'208";a="570447579"
Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66])
 by FMSMGA003.fm.intel.com with ESMTP; 29 Sep 2015 04:29:27 -0700
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.84]) by
 IRSMSX152.ger.corp.intel.com ([169.254.6.126]) with mapi id 14.03.0248.002;
 Tue, 29 Sep 2015 12:29:26 +0100
From: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Thread-Topic: [dpdk-dev] [PATCHv4 2/9] null: fix segfault when null_pmd
 added to bonding
Thread-Index: AQHQ+l37Z9tD+DJXMk6/2WfzLCIhL55TP6bw////RQCAAB9VUA==
Date: Tue, 29 Sep 2015 11:29:26 +0000
Message-ID: <3042915272161B4EB253DA4D77EB373A14DF7AEA@IRSMSX102.ger.corp.intel.com>
References: <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com>
 <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com>
 <1436981189-3320-3-git-send-email-tomaszx.kulasek@intel.com>
 <5609F65A.6050208@igel.co.jp>
 <3042915272161B4EB253DA4D77EB373A14DF7A48@IRSMSX102.ger.corp.intel.com>
 <560A68DA.4060309@igel.co.jp>
In-Reply-To: <560A68DA.4060309@igel.co.jp>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCHv4 2/9] null: fix segfault when null_pmd added
 to bonding
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Sep 2015 11:29:29 -0000

> -----Original Message-----
> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp]
> Sent: Tuesday, September 29, 2015 12:33
> To: Kulasek, TomaszX
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCHv4 2/9] null: fix segfault when null_pmd
> added to bonding
>=20
> On 2015/09/29 18:39, Kulasek, TomaszX wrote:
> > Hi Tetsuya,
> >
> >> Thanks for extending null pmd features.
> >> Is it possible to use rte_null_pmd here?
> >> Could you please check ring pmd? It may also uses rte_ring_pmd for
> >> link status callback.
> >>
> >> Tetsuya
> > My first attempt was to use ring pmd, and there's no such an issue
> with it. It works pretty well in bonding.
> >
> > Tomasz.
>=20
> HI Tomasz,
>=20
>=20
> Sorry, my English is wrong.
> 'rte_null_pmd' is defined like below.
>=20
> static struct eth_driver rte_null_pmd =3D {
>         .pci_drv =3D {
>                 .name =3D "rte_null_pmd",
>                 .drv_flags =3D RTE_PCI_DRV_DETACHABLE,
>         },
> };
>=20
> I guess you may be able to use 'rte_null_pmd' instead of allocating one
> more eth_driver structure like below.
>=20
>     struct eth_driver *eth_drv =3D NULL;
>     eth_drv =3D rte_zmalloc_socket(name, sizeof(*eth_drv), 0, numa_node);
>=20
> Is it possible to use 'rte_null_pmd'?
>=20
> Tetsuya

Yes, you're right. This malloc can be removed.

Tomasz