From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7C0F48E9A for ; Fri, 30 Oct 2015 14:50:16 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 30 Oct 2015 06:50:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,218,1444719600"; d="scan'208";a="591020582" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by FMSMGA003.fm.intel.com with ESMTP; 30 Oct 2015 06:50:15 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.98]) by IRSMSX107.ger.corp.intel.com ([169.254.10.49]) with mapi id 14.03.0248.002; Fri, 30 Oct 2015 13:50:13 +0000 From: "Kulasek, TomaszX" To: Tetsuya Mukawa Thread-Topic: [dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd added to bonding Thread-Index: AQHRENj+3A7Bph0OwEm7CSlNDLx59J6A5YAQgAEtDwCAAf0hQA== Date: Fri, 30 Oct 2015 13:50:13 +0000 Message-ID: <3042915272161B4EB253DA4D77EB373A14E0E823@IRSMSX102.ger.corp.intel.com> References: <1443621905-7872-1-git-send-email-tomaszx.kulasek@intel.com> <1444989651-6236-1-git-send-email-tomaszx.kulasek@intel.com> <1444989651-6236-3-git-send-email-tomaszx.kulasek@intel.com> <7064813.L2uCrhhELF@xps13> <3042915272161B4EB253DA4D77EB373A14E0C5E1@IRSMSX102.ger.corp.intel.com> <5631C878.8060003@igel.co.jp> In-Reply-To: <5631C878.8060003@igel.co.jp> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd added to bonding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2015 13:50:16 -0000 > -----Original Message----- > From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] > Sent: Thursday, October 29, 2015 08:19 > To: Kulasek, TomaszX > Cc: Thomas Monjalon; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 2/9] null: fix segfault when null_pmd > added to bonding >=20 > On 2015/10/28 22:43, Kulasek, TomaszX wrote: > >> -----Original Message----- > >> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > >> Sent: Tuesday, October 27, 2015 17:59 > >> To: Kulasek, TomaszX > >> Cc: dev@dpdk.org; Tetsuya Mukawa > >> Subject: Re: [dpdk-dev] [PATCH v6 2/9] null: fix segfault when > >> null_pmd added to bonding > >> > >> Hi, > >> There is no change in v6 for this patch which was acked by Tetsuya. > >> So why not keep the Acked-by below your Signed-off-by? > >> > >> It seems patches 2, 3, 4 and 5 were Acked by Tetsuya. > >> Other acks I'm missing? > >> > > Hi, > > > > Patches 4 and 5 were changed due to the Tetsuya's suggestions and > already reviewed. There are not big changes, but I'm not sure if it > should be reacked by Tetsuya, or I can just copy ack? > > > > Tomasz >=20 > Hi Tomasz, >=20 > Could you please check Bernard's patch series? > - [PATCH v5 00/28] remove pci driver from vdevs He tries to remove > pci_drv from PMD. >=20 > It seems your below patch will be affected by his patch. > - null: fix segfault when null_pmd added to bonding >=20 > I just wonder your bonding RSS patch works without below fixing. > drivers/net/null/rte_eth_null.c : > + pci_dev->driver =3D &rte_null_pmd.pci_drv; >=20 > Anyway, Could you please check him patches? >=20 > Thanks, > Tetsuya Hi Tetsuya, I've just checked Bernard's patches and it seems that it can be safely remo= ved from here. It's not used in RSS implementation, so have no impact on it= . I'm sending patchset v7 with copied your acks, as Thomas suggested, if you = have no other objections. Tomasz