From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <tomaszx.kulasek@intel.com> Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id AEC038E5D for <dev@dpdk.org>; Tue, 2 Feb 2016 13:01:18 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 02 Feb 2016 04:01:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,384,1449561600"; d="scan'208";a="645801291" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by FMSMGA003.fm.intel.com with ESMTP; 02 Feb 2016 04:01:18 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 2 Feb 2016 12:01:15 +0000 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.97]) by irsmsx111.ger.corp.intel.com ([169.254.2.198]) with mapi id 14.03.0248.002; Tue, 2 Feb 2016 12:01:15 +0000 From: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com> To: Ravi Kerur <rkerur@gmail.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH v1] Modify and modularize l3fwd code Thread-Index: AQHRPEUDl37dgxvaWUyL4ncRhavcop7WEbKAgELXfXA= Date: Tue, 2 Feb 2016 12:01:14 +0000 Message-ID: <3042915272161B4EB253DA4D77EB373A14E44133@IRSMSX102.ger.corp.intel.com> References: <1450739511-5868-1-git-send-email-rkerur@gmail.com> <1450739573-5915-1-git-send-email-rkerur@gmail.com> In-Reply-To: <1450739573-5915-1-git-send-email-rkerur@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] Modify and modularize l3fwd code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 02 Feb 2016 12:01:19 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kerur > Sent: Tuesday, December 22, 2015 00:13 > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v1] Modify and modularize l3fwd code >=20 > v1: > > Rebase to latest code base for DPDK team review. >=20 > Intel team's (Konstantin, Bruce and Declan) review comments >=20 > v4<-v3: > > Fix code review comments from Konstantin > > Move buffer optimization code into l3fwd_lpm_sse.h > and l3fwd_em_sse.h for LPM and EM respectively > > Add compile time __SSE4_1__ for header file inclusion > > Tested with CONFIG_RTE_MACHINE=3Ddefault for non > __SSE4_1__ compilation and build > > Compiled for GCC 4.8.4 and 5.1 on Ubuntu 14.04 >=20 > v3<-v2: > > Fix code review comments from Bruce > > Fix multiple static definitions > > Move local #defines to C files, common #defines > to H file. > > Rename ipv4_l3fwd_route to ipv4_l3fwd_lpm and ipv4_l3fwd_em > > Rename ipv6_l3fwd_route to ipv6_l3fwd_lpm and ipv6_l3fwd_lpm > > Pass additional parameter to send_single_packet > > Compiled for GCC 4.8.4 and 5.1 on Ubuntu 14.04 >=20 > v2<-v1: > > Fix errors in GCC 5.1 > > Restore "static inline" functions, rearrange > functions to take "static inline" into account > > Duplicate main_loop for LPM and EM >=20 > v1: > > Split main.c into following 3 files > > main.c, (parsing, buffer alloc, and other utilities) > > l3fwd_lpm.c, (Longest Prefix Match functions) > > l3fwd_em.c, (Exact Match f.e. Hash functions) > > l3fwd.h, (Common defines and prototypes) >=20 > > Select LPM or EM based on run time selection f.e. > > l3fwd -c 0x1 -n 1 -- -p 0x1 -E ... (Exact Match) > > l3fwd -c 0x1 -n 1 -- -p 0x1 -L ... (LPM) >=20 > > Options "E" and "L" are mutualy-exclusive. >=20 > > Use function pointers during initialiation of relevant > data structures. >=20 > > Remove unwanted #ifdefs in the code with exception to > > DO_RFC_1812_CHECKS > > RTE_MACHINE_CPUFLAG_SSE4_2 >=20 > > Compiled for > > i686-native-linuxapp-gcc > > x86_64-native-linuxapp-gcc > > x86_x32-native-linuxapp-gcc > > x86_64-native-bsdapp-gcc >=20 > > Tested on > > Ubuntu 14.04 (GCC 4.8.4) > > FreeBSD 10.0 (GCC 4.8) > > I217 and I218 respectively. >=20 > Signed-off-by: Ravi Kerur <rkerur@gmail.com> > --- Tested-by: Tomasz Kulasek <tomaszx.kulasek@intel.com> Acked-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>