From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomaszx.kulasek@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 485D22B9D
 for <dev@dpdk.org>; Thu, 10 Mar 2016 18:16:06 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga102.jf.intel.com with ESMTP; 10 Mar 2016 09:15:55 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,316,1455004800"; d="scan'208";a="667152371"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by FMSMGA003.fm.intel.com with ESMTP; 10 Mar 2016 09:15:54 -0800
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.19]) by
 IRSMSX103.ger.corp.intel.com ([169.254.3.239]) with mapi id 14.03.0248.002;
 Thu, 10 Mar 2016 17:15:53 +0000
From: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v3 1/2] ethdev: add buffered tx api
Thread-Index: AQHRerv5KNd9fQAV4USKNnN8IjLF359S3QOAgAAOVGA=
Date: Thu, 10 Mar 2016 17:15:52 +0000
Message-ID: <3042915272161B4EB253DA4D77EB373A14E6B02D@IRSMSX102.ger.corp.intel.com>
References: <1456333729-3804-1-git-send-email-tomaszx.kulasek@intel.com>
 <1457607478-2184-1-git-send-email-tomaszx.kulasek@intel.com>
 <1457607478-2184-2-git-send-email-tomaszx.kulasek@intel.com>
 <4053591.4SyQbLBBNH@xps13>
In-Reply-To: <4053591.4SyQbLBBNH@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add buffered tx api
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2016 17:16:06 -0000


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, March 10, 2016 17:24
> To: Kulasek, TomaszX <tomaszx.kulasek@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add buffered tx api
>=20
> 2016-03-10 11:57, Tomasz Kulasek:
> > +struct rte_eth_dev_tx_buffer {
> > +	buffer_tx_error_fn callback;
> > +	void *userdata;
>=20
> What about renaming this fields as
> - error_callback
> - error_userdata ?
>=20
> > +	uint16_t size;           /**< Size of buffer for buffered tx */
> > +	uint16_t length;
>=20
> Maybe a comment "Number of packets in the array" to be sure?
>=20
> > +	struct rte_mbuf *pkts[];
>=20
> A comment? "Pending packets to be sent on explicit flush or when full" ?
>=20
> [...]
> > +DPDK_16.04 {
> > +	global:
> > +
> > +	rte_eth_tx_buffer_drop_callback;
> > +	rte_eth_tx_buffer_count_callback;
> > +	rte_eth_tx_buffer_init;
> > +	rte_eth_tx_buffer_set_err_callback;
>=20
> Please keep alphabetical order.
>=20

Ok, I'll send v4