From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7CC845581 for ; Mon, 19 Sep 2016 17:29:11 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP; 19 Sep 2016 08:29:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,362,1470726000"; d="scan'208";a="10978867" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga005.jf.intel.com with ESMTP; 19 Sep 2016 08:29:09 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 19 Sep 2016 16:29:08 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.248]) by IRSMSX156.ger.corp.intel.com ([169.254.3.80]) with mapi id 14.03.0248.002; Mon, 19 Sep 2016 16:29:08 +0100 From: "Kulasek, TomaszX" To: "Ananyev, Konstantin" , "dev@dpdk.org" CC: "jerin.jacob@caviumnetworks.com" Thread-Topic: [dpdk-dev] [PATCH v2 1/6] ethdev: add Tx preparation Thread-Index: AQHSDQSpKvdPZmq79UuCyKsEmv1A+qCAwYeAgAAxiAA= Date: Mon, 19 Sep 2016 15:29:07 +0000 Message-ID: <3042915272161B4EB253DA4D77EB373A14F1A294@IRSMSX102.ger.corp.intel.com> References: <1472228578-6980-1-git-send-email-tomaszx.kulasek@intel.com> <1473691487-10032-1-git-send-email-tomaszx.kulasek@intel.com> <1473691487-10032-2-git-send-email-tomaszx.kulasek@intel.com> <2601191342CEEE43887BDE71AB9772583F0B583F@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772583F0B583F@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add Tx preparation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2016 15:29:11 -0000 Hi Konstantin, > -----Original Message----- > From: Ananyev, Konstantin > Sent: Monday, September 19, 2016 15:03 > To: Kulasek, TomaszX ; dev@dpdk.org > Cc: jerin.jacob@caviumnetworks.com > Subject: RE: [dpdk-dev] [PATCH v2 1/6] ethdev: add Tx preparation >=20 > Hi Tomasz, >=20 > > [...] > > + > > +#ifdef RTE_ETHDEV_TX_PREP >=20 > Sorry for being a bit late on that discussion, but what the point of > having that config macro (RTE_ETHDEV_TX_PREP ) at all? > As I can see right now, if driver doesn't setup tx_pkt_prep, then nb_pkts > would be return anyway... >=20 > BTW, there is my another question - should it be that way? > Shouldn't we return 0 (and set rte_errno=3DENOTSUP) here if dev->tx_pk_pr= ep > =3D=3D NULL? >=20 It's an answer to the Jerin's request discussed here: http://dpdk.org/ml/ar= chives/dev/2016-September/046437.html When driver doesn't support tx_prep, default behavior is "we don't know req= uirements, so we have nothing to do here". It will simplify application log= ic and improve performance for these drivers, I think. Catching this error = with every burst may be problematic. As for RTE_ETHDEV_TX_PREP macro, suggested by Jerin in the same thread, I s= till don't think It's the best solution of the problem described by him. I = have added it here for further discussion. Jerin, have you something to add? Tomasz.