From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D4EF1902 for ; Fri, 14 Oct 2016 16:03:03 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP; 14 Oct 2016 07:03:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,493,1473145200"; d="scan'208";a="19597531" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga005.fm.intel.com with ESMTP; 14 Oct 2016 07:03:01 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.198]) by IRSMSX153.ger.corp.intel.com ([169.254.9.140]) with mapi id 14.03.0248.002; Fri, 14 Oct 2016 15:03:01 +0100 From: "Kulasek, TomaszX" To: Thomas Monjalon CC: "dev@dpdk.org" , "Ananyev, Konstantin" Thread-Topic: [PATCH v5 1/6] ethdev: add Tx preparation Thread-Index: AQHSJYcDELA1YhG+e0aNOH6T0tmn9KCn+e1w Date: Fri, 14 Oct 2016 14:02:59 +0000 Message-ID: <3042915272161B4EB253DA4D77EB373A14F35FFC@IRSMSX102.ger.corp.intel.com> References: <20160930090039.10164-1-tomaszx.kulasek@intel.com> <1476380222-9900-1-git-send-email-tomaszx.kulasek@intel.com> <1476380222-9900-2-git-send-email-tomaszx.kulasek@intel.com> <8024593.WaNfoiub2G@xps13> In-Reply-To: <8024593.WaNfoiub2G@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/6] ethdev: add Tx preparation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2016 14:03:04 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, October 13, 2016 21:21 > To: Kulasek, TomaszX > Cc: dev@dpdk.org; Ananyev, Konstantin > Subject: Re: [PATCH v5 1/6] ethdev: add Tx preparation >=20 > Hi, >=20 > 2016-10-13 19:36, Tomasz Kulasek: > > Added API for `rte_eth_tx_prep` > > > > uint16_t rte_eth_tx_prep(uint8_t port_id, uint16_t queue_id, > > struct rte_mbuf **tx_pkts, uint16_t nb_pkts) > > > > Added fields to the `struct rte_eth_desc_lim`: > > > > uint16_t nb_seg_max; > > /**< Max number of segments per whole packet. */ > > > > uint16_t nb_mtu_seg_max; > > /**< Max number of segments per one MTU */ > > > > Created `rte_pkt.h` header with common used functions: >=20 > Same comment as in previous revision: > this description lacks the usability and performance considerations. >=20 > > +static inline uint16_t > > +rte_eth_tx_prep(uint8_t port_id __rte_unused, uint16_t queue_id > __rte_unused, > > + struct rte_mbuf **tx_pkts __rte_unused, uint16_t nb_pkts) >=20 > Doxygen still do not parse it well (same issue as previous revision). >=20 > > +/** > > + * Fix pseudo header checksum for TSO and non-TSO tcp/udp packets > before > > + * hardware tx checksum. > > + * For non-TSO tcp/udp packets full pseudo-header checksum is counted > and set. > > + * For TSO the IP payload length is not included. > > + */ > > +static inline int > > +rte_phdr_cksum_fix(struct rte_mbuf *m) >=20 > You probably don't need this function since the recent improvements from > Olivier. Do you mean this improvement: "net: add function to calculate a checksum in= a mbuf" http://dpdk.org/dev/patchwork/patch/16542/ I see only full raw checksum computation on mbuf in Olivier patches, while = this function counts only pseudo-header checksum to be used with tx offload= . Tomasz