From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6E4685934 for ; Mon, 17 Oct 2016 18:25:10 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 17 Oct 2016 09:25:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,357,1473145200"; d="scan'208";a="890843043" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga003.jf.intel.com with ESMTP; 17 Oct 2016 09:25:07 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by irsmsx110.ger.corp.intel.com (163.33.3.25) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 17 Oct 2016 17:25:06 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.198]) by IRSMSX156.ger.corp.intel.com ([169.254.3.80]) with mapi id 14.03.0248.002; Mon, 17 Oct 2016 17:25:06 +0100 From: "Kulasek, TomaszX" To: Thomas Monjalon CC: "dev@dpdk.org" , "Ananyev, Konstantin" , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH v5 1/6] ethdev: add Tx preparation Thread-Index: AQHSJYcDELA1YhG+e0aNOH6T0tmn9KCn+e1w///2WQCABObfsA== Date: Mon, 17 Oct 2016 16:25:06 +0000 Message-ID: <3042915272161B4EB253DA4D77EB373A14F36B21@IRSMSX102.ger.corp.intel.com> References: <20160930090039.10164-1-tomaszx.kulasek@intel.com> <8024593.WaNfoiub2G@xps13> <3042915272161B4EB253DA4D77EB373A14F35FFC@IRSMSX102.ger.corp.intel.com> <3567043.JXAYMJHPG7@xps13> In-Reply-To: <3567043.JXAYMJHPG7@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/6] ethdev: add Tx preparation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 16:25:10 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, October 14, 2016 16:20 > To: Kulasek, TomaszX > Cc: dev@dpdk.org; Ananyev, Konstantin ; > olivier.matz@6wind.com > Subject: Re: [dpdk-dev] [PATCH v5 1/6] ethdev: add Tx preparation >=20 > 2016-10-14 14:02, Kulasek, TomaszX: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2016-10-13 19:36, Tomasz Kulasek: > > > > +/** > > > > + * Fix pseudo header checksum for TSO and non-TSO tcp/udp packets > > > before > > > > + * hardware tx checksum. > > > > + * For non-TSO tcp/udp packets full pseudo-header checksum is > > > > + counted > > > and set. > > > > + * For TSO the IP payload length is not included. > > > > + */ > > > > +static inline int > > > > +rte_phdr_cksum_fix(struct rte_mbuf *m) > > > > > > You probably don't need this function since the recent improvements > > > from Olivier. > > > > Do you mean this improvement: "net: add function to calculate a checksu= m > in a mbuf" > > http://dpdk.org/dev/patchwork/patch/16542/ > > > > I see only full raw checksum computation on mbuf in Olivier patches, > while this function counts only pseudo-header checksum to be used with tx > offload. >=20 > OK. Please check what exists already in librte_net (especially rte_ip.h) > and try to re-use code if possible. Thanks I have already sent v6 with requested changes in Friday. There's no equival= ent of rte_phdr_cksum_fix in librte_net. This function already uses rte_ipv= 4_phdr_cksum and rte_ipv6_phdr_cksum and there's nothing similar on the hig= her level to simplify it even more. Tomasz