From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C08A72BA8 for ; Wed, 7 Dec 2016 13:01:06 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP; 07 Dec 2016 04:01:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="39903393" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga005.fm.intel.com with ESMTP; 07 Dec 2016 04:00:59 -0800 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.79]) by irsmsx105.ger.corp.intel.com ([169.254.7.43]) with mapi id 14.03.0248.002; Wed, 7 Dec 2016 12:00:59 +0000 From: "Kulasek, TomaszX" To: "Yigit, Ferruh" , "dev@dpdk.org" CC: "Ananyev, Konstantin" , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in csum engine Thread-Index: AQHSUHsQFLv9lEs9TUec+DGDPoJwMaD8W/hQ Date: Wed, 7 Dec 2016 12:00:58 +0000 Message-ID: <3042915272161B4EB253DA4D77EB373A14F58E37@IRSMSX102.ger.corp.intel.com> References: <1477486575-25148-1-git-send-email-tomaszx.kulasek@intel.com> <1479922585-8640-1-git-send-email-tomaszx.kulasek@intel.com> <1479922585-8640-7-git-send-email-tomaszx.kulasek@intel.com> <067ddc1b-5b28-47fe-8947-84a218357488@intel.com> In-Reply-To: <067ddc1b-5b28-47fe-8947-84a218357488@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in csum engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 12:01:07 -0000 Hi, > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, December 7, 2016 12:14 > To: Kulasek, TomaszX ; dev@dpdk.org > Cc: Ananyev, Konstantin ; > olivier.matz@6wind.com > Subject: Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in > csum engine >=20 > On 11/23/2016 5:36 PM, Tomasz Kulasek wrote: > > Added "csum txprep (on|off)" command which allows to switch to the tx > > path using Tx preparation API. > > > > By default unchanged implementation is used. > > > > Using Tx preparation path, pseudo header calculation for udp/tcp/tso > > packets from application, and used Tx preparation API for packet > > preparation and verification. > > > > Adding additional step to the csum engine costs about 3-4% of > > performance drop, on my setup with ixgbe driver. It's caused mostly by > > the need of reaccessing and modification of packet data. > > > > Signed-off-by: Tomasz Kulasek > > Acked-by: Konstantin Ananyev > > --- > > app/test-pmd/cmdline.c | 49 > +++++++++++++++++++++++++++++++++++++++++++++++ > > app/test-pmd/csumonly.c | 33 ++++++++++++++++++++++++------- > > app/test-pmd/testpmd.c | 5 +++++ > > app/test-pmd/testpmd.h | 2 ++ > > 4 files changed, 82 insertions(+), 7 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > 63b55dc..373fc59 100644 > <...> > > +cmdline_parse_inst_t cmd_csum_txprep =3D { > > + .f =3D cmd_csum_txprep_parsed, > > + .data =3D NULL, > > + .help_str =3D "enable/disable tx preparation path for csum engine: " > > + "csum txprep on|off", >=20 > Can you please format help string as: > "cmd fixed_string fixed|string|options : Description" > see commit 26faac80327f >=20 > above becomes: > "csum txprep on|off: Enable/Disable tx preparation path for csum engine" >=20 > <...> Sure, thanks. Tomasz