From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomaszx.kulasek@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id EDC132B96
 for <dev@dpdk.org>; Wed,  7 Dec 2016 13:12:31 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga102.fm.intel.com with ESMTP; 07 Dec 2016 04:12:30 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="1078665218"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by fmsmga001.fm.intel.com with ESMTP; 07 Dec 2016 04:12:30 -0800
Received: from irsmsx102.ger.corp.intel.com ([169.254.2.79]) by
 IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0248.002;
 Wed, 7 Dec 2016 12:12:24 +0000
From: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>, "Yigit, Ferruh"
 <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in csum
 engine
Thread-Index: AQHSUHsQFLv9lEs9TUec+DGDPoJwMaD8YiIAgAACvIA=
Date: Wed, 7 Dec 2016 12:12:23 +0000
Message-ID: <3042915272161B4EB253DA4D77EB373A14F58E53@IRSMSX102.ger.corp.intel.com>
References: <1477486575-25148-1-git-send-email-tomaszx.kulasek@intel.com>
 <1479922585-8640-1-git-send-email-tomaszx.kulasek@intel.com>
 <1479922585-8640-7-git-send-email-tomaszx.kulasek@intel.com>
 <067ddc1b-5b28-47fe-8947-84a218357488@intel.com>
 <B27915DBBA3421428155699D51E4CFE20267036C@IRSMSX103.ger.corp.intel.com>
In-Reply-To: <B27915DBBA3421428155699D51E4CFE20267036C@IRSMSX103.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in csum
 engine
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Dec 2016 12:12:32 -0000

Hi John,

> -----Original Message-----
> From: Mcnamara, John
> Sent: Wednesday, December 7, 2016 13:01
> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Kulasek, TomaszX
> <tomaszx.kulasek@intel.com>; dev@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>;
> olivier.matz@6wind.com
> Subject: RE: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in
> csum engine
>=20
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> > Sent: Wednesday, December 7, 2016 11:14 AM
> > To: Kulasek, TomaszX <tomaszx.kulasek@intel.com>; dev@dpdk.org
> > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>;
> > olivier.matz@6wind.com
> > Subject: Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in
> > csum engine
> >
> > ...
> > <...>
> > > +cmdline_parse_inst_t cmd_csum_txprep =3D {
> > > +	.f =3D cmd_csum_txprep_parsed,
> > > +	.data =3D NULL,
> > > +	.help_str =3D "enable/disable tx preparation path for csum engine: =
"
> > > +	"csum txprep on|off",
> >
> > Can you please format help string as:
> > "cmd fixed_string fixed|string|options <variable>: Description"
> > see commit 26faac80327f
> >
> > above becomes:
> > "csum txprep on|off: Enable/Disable tx preparation path for csum engine=
"
> >
>=20
>=20
> Also, does this require an update to the testpmd docs?
>=20
>=20

Yes, I think. I will add adequate description to the docs.

Tomasz