From: Thomas Monjalon <thomas@monjalon.net>
To: Adrian Moreno <amorenoz@redhat.com>
Cc: dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com,
ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH
Date: Fri, 07 Aug 2020 13:35:41 +0200 [thread overview]
Message-ID: <3043410.84Z9Aqy7iH@thomas> (raw)
In-Reply-To: <3554258.jWZQtkDrRB@thomas>
05/08/2020 15:54, Thomas Monjalon:
> 05/08/2020 15:34, Adrian Moreno:
> > On 8/5/20 11:12 AM, Thomas Monjalon wrote:
> > > 04/08/2020 09:38, Adrian Moreno:
> > >> --- a/devtools/checkpatches.sh
> > >> +++ b/devtools/checkpatches.sh
> > >> @@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
> > >> PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\
> > >> SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\
> > >> LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
> > >> -NEW_TYPEDEFS,COMPARISON_TO_NULL"
> > >> +NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH"
> > >
> > > I would add this option between PREFER_KERNEL_TYPES and BIT_MACRO
> > > to maintain a bit of logic ordering.
> > >
> > OK. I'll reorder it if the final decision is to ignore the check.
>
> Yes thanks
Applied with above change.
prev parent reply other threads:[~2020-08-07 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 7:38 Adrian Moreno
2020-08-04 7:43 ` Ferruh Yigit
2020-08-04 8:00 ` Xia, Chenbo
2020-08-05 9:12 ` Thomas Monjalon
2020-08-05 13:34 ` Adrian Moreno
2020-08-05 13:54 ` Thomas Monjalon
2020-08-07 11:35 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3043410.84Z9Aqy7iH@thomas \
--to=thomas@monjalon.net \
--cc=amorenoz@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).