From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D09242DAB; Tue, 4 Jul 2023 16:11:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B38F42BFE; Tue, 4 Jul 2023 16:11:18 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 4144140F18 for ; Tue, 4 Jul 2023 16:11:17 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C21CC5C02A3; Tue, 4 Jul 2023 10:11:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 04 Jul 2023 10:11:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1688479876; x=1688566276; bh=ncnLqn36JaxFIlDiFpx0RmqtcEEn5WIgLjQ Oo4Sro7Q=; b=d9HiXFv+HDXp+yUtPcAqMuNkrQ0SYfyzh3M56CSgDDspuwk7BSQ OwGg23+mRSFlx+qW2Ss2hhPeMP8yf5JyaSArHqOIp6CCblsgWSr9gHkiwkS5aNJZ BSiUHLo38pA3E+OZ3HeC3KnbWy/IGwp4BJ3WiK2da0yy6YSq1hL2pxhupA+QfxDH wXND+zFarxTADsJBJGw3v+oSHWRdn26sNm+nyebhCRneG0obARCFCzs+/wDldaoE HaOWDyHba5wCVhZX3M7n39ZkBMK4vjZAxDDYcI6KvgewCs3i37YhMe8T1kKZibeP b987iqO+Lk5Y5tLpz9+7Pwg3E5hbNB8sZqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1688479876; x=1688566276; bh=ncnLqn36JaxFIlDiFpx0RmqtcEEn5WIgLjQ Oo4Sro7Q=; b=naqFQbeJvH2rh8bFKvOCunSDBrXOhnt5cYVGk3ur5CsmYOdp6y3 dVHUcHbyv23190Q8yB8Dd6BwRTMdrY4NLZWGd70zMY5Xe2kSbUqyOoHdT0sPrtXy ZKgVeQ3YymEbuHZo036K1OXYKXjOUDz2OnfLdmJidtA2wESTmq2lduCEHJVg4wpJ y8QwMdrfDgX4WMMsnlLuluU84A8EN/sQQEsaiHWjKimxpFC/E7R+Ll/NgqX42KXL sVsThertvK484zBGU55QUA/+7BbwSCuvNWxN4RnZIMRycOxwg5MAHLPX9pxp4pfE xy7jcVHomtrhANozeDqDewb6V5xSFNzMzRg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudeggdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Jul 2023 10:11:15 -0400 (EDT) From: Thomas Monjalon To: David Marchand , Jie Hai Cc: honnappa.nagarahalli@arm.com, konstantin.v.ananyev@yandex.ru, dev@dpdk.org, liudongdong3@huawei.com, bruce.richardson@intel.com Subject: Re: [PATCH v4 3/3] ring: add telemetry cmd for ring info Date: Tue, 04 Jul 2023 16:11:14 +0200 Message-ID: <3043990.CbtlEUcBR6@thomas> In-Reply-To: <2c9f8137-4af7-d139-c69a-76d03208c669@huawei.com> References: <20230131022841.10775-1-haijie1@huawei.com> <4273274.ejJDZkT8p0@thomas> <2c9f8137-4af7-d139-c69a-76d03208c669@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 04/07/2023 10:04, Jie Hai: > On 2023/6/20 22:34, Thomas Monjalon wrote: > > 20/06/2023 10:14, Jie Hai: > >> On 2023/2/20 20:55, David Marchand wrote: > >>> On Fri, Feb 10, 2023 at 3:50 AM Jie Hai wrote: > >>>> > >>>> This patch supports dump of ring information by its name. > >>>> An example using this command is shown below: > >>>> > >>>> --> /ring/info,MP_mb_pool_0 > >>>> { > >>>> "/ring/info": { > >>>> "name": "MP_mb_pool_0", > >>>> "socket": 0, > >>>> "flags": "0x0", > >>>> "producer_type": "MP", > >>>> "consumer_type": "MC", > >>>> "size": 262144, > >>>> "mask": "0x3ffff", > >>>> "capacity": 262143, > >>>> "used_count": 153197, > >>>> "consumer_tail": 2259, > >>>> "consumer_head": 2259, > >>>> "producer_tail": 155456, > >>>> "producer_head": 155456, > >>> > >>> What would an external user make of such an information? > >>> > >>> I'd like to have a better idea what your usecase is. > >>> If it is for debugging, well, gdb is probably a better candidate. > >>> > >>> > >> Hi David, > >> Thanks for your question and I'm sorry for getting back to you so late. > >> There was a problem with my mailbox and I lost all my mails. > >> > >> The ring information exported by telemetry can be used to check the ring > >> status periodically during normal use. When an error occurs, the fault > >> cause can be deduced based on the information. > >> GDB is more suitable for locating errors only when they are sure that > >> errors will occur. > > > > Yes, when an error occurs, you can use GDB, > > and you don't need all these internal values in telemetry. > > > > > Hi, David, Thomas, > > Would it be better to delete the last four items? > "consumer_tail": 2259, > "consumer_head": 2259, > "producer_tail": 155456, > "producer_head": 155456, Yes it would be better. David, other maintainers, would it make the telemetry command a good idea?