From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBBAEA0C4E; Tue, 2 Nov 2021 13:08:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3F254068F; Tue, 2 Nov 2021 13:08:43 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 7775340689 for ; Tue, 2 Nov 2021 13:08:42 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10155"; a="231198060" X-IronPort-AV: E=Sophos;i="5.87,202,1631602800"; d="scan'208";a="231198060" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 05:08:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,202,1631602800"; d="scan'208";a="540816958" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga008.fm.intel.com with ESMTP; 02 Nov 2021 05:08:41 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 05:08:40 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 2 Nov 2021 05:08:40 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 2 Nov 2021 05:08:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rs1/hzAnGCI5Ulk8uDVuu4ZVjhqbqOgutNot7Aa8iM8zgy7s/IuA3TfjYDKWyvtKDduotN+seDycrN3ABUgZx4vMDD1dhCXEkh6snVTih64ADMJ9uEyeq+036U+fOZ0saR7Eggo+uzw155TU/MvRGCYk7pRXw3dIFzcs78tXJNnDbEyxpCCBlPr6UejeO2IiXjBPMya3uN2cVlxRwTCUJUiUYW3pSe9vnXupulLoEksRWUlhKG572hyrn3uJLNq5w2XrA45bqlvUyrOT1KMEyygfHqyaNpVPgOwYcN6I+L6qsGVtNSjci5sMD9Cxj0pwgWmZRCx1cQ08MONwsl1CYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GRb1+fdPv2+4BDMKUnZFpuCpItOY+9OHm+5nq9ajBZI=; b=lUFg3HsZvoz2nv1tg08pwVOtET7X1Nv/2JecllgtV/0kjljh2/b2a45Yku2JlAL5eVYCmrZbXIFgiJW/4ZOCrvKttM6gpaRMkbkPjo4/SP314tOvYjImbkeboM3UnAxArYXqv53EPhT57HSzZWsD+NlU1wVJxijQd+1A0Q/lB596Cnyz4GyBRa8iqnPebeiz47TUxwvX/k0MtcXVGifdPfQ2l+wfm1bpmcq7nLeoP5WMtb9KOmUKfmMNeZm5EF6Flib9Q5ZhV16lAexfSJ5ckgTWZONuZzWRaGDEiSuf8t1SQ/49UnxjawBxWTxQJZQ0N9xWm9fSlGJCxWYIW1lW2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GRb1+fdPv2+4BDMKUnZFpuCpItOY+9OHm+5nq9ajBZI=; b=d9rThZbKW9PIfclTcEFoEIY7AEj/b8x9ev+zw63E7TEtSydYrjNk3Yc0n2Pk2wLS8VUHfJC5QHXCg1GTljT0Xv9prVCqHjkNDZEdfxrY7hrS3QsGtG1YQYGbJ3qmK4GqFwqQI0moiKYba89bvaviw4RChnrql2XTI3SXsLcOZ+8= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH7PR11MB5861.namprd11.prod.outlook.com (2603:10b6:510:133::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Tue, 2 Nov 2021 12:08:39 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.020; Tue, 2 Nov 2021 12:08:39 +0000 Message-ID: <304566a3-1021-bd55-bfb5-a2e69af9b308@intel.com> Date: Tue, 2 Nov 2021 12:08:33 +0000 Content-Language: en-US To: Thomas Monjalon CC: , Joe Perches , References: <20211101133533.3402007-1-ferruh.yigit@intel.com> <5473001.4jAN4JvoLB@thomas> <1f940709-5b29-3a80-6966-8938d5034f3d@intel.com> <12489504.UicEPBppVI@thomas> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <12489504.UicEPBppVI@thomas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB7PR05CA0015.eurprd05.prod.outlook.com (2603:10a6:10:36::28) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB7PR05CA0015.eurprd05.prod.outlook.com (2603:10a6:10:36::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.17 via Frontend Transport; Tue, 2 Nov 2021 12:08:38 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b371cd2b-3f71-4968-308d-08d99df9815c X-MS-TrafficTypeDiagnostic: PH7PR11MB5861: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:431; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PyVly7cqSZMzW8sKY3Q5Qo4Ok2ZfoQ3YIkpQqmCp9GSIbq3AmDS9moRz3fxc9X0ufZnbX6U+mHUnam0K0jg+6rwqNmaQqO67RoDgifhO094+I5A2QdlA2I0A4ExJWsn8slv+YhwNfxuwpx02jUfrN2rLS9+cHjfCLHN6rVV4TLXik9cdc+lbBS53FDNzcedjdRwEI2gEacV/HNXU42Syech8HRNhUb3+c2TjC56BXuv/6dmjioDvh2vq4u1NKpxfJfrqlDVz3jgEMoB+aFSMLpS9leWgtDRUUa1LhOogEXS/6gZZC39jTSdHr8vozX0x3iy3sVGFv7U+p8c4PajVuEGT8isPRBhWySeP2/oj3mkVGsmWAedzHu0TbOxv6Nhmi7lbI0U/Hd8SDmCrFzpWKfMVR6rhNOOlprVUosWGzAKSEM/c5k9Xp9H1+7eUiUxjiUJ9e0lrdCpUdtD5FWGfZwJEuoMVDE2KSNwDosbw2Hy+0cCvNAraWv0RxOSKWRwVjD8KUOEeFmElwkiy5IfItabFVG3QntudCUd6HtxpZSaUtnG7APBRprv6yJBNxxNjfMIg+p8yOqXhhClMmeP2RnKmVsltr8hozVS9ICcZllrRLpjpH12Fp2gRAXBokuL/yNOC4L63gLMjdyuvKnSubOee4FFLIAZTzuCcqvk6TEFt8A8bOfGkSN2sXsVjS/STm4Zrr4Hz9ezdGW96UkS+Jdt0P3dAcRjrRi8pkPjohfY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66556008)(66476007)(66946007)(82960400001)(508600001)(26005)(53546011)(31686004)(4326008)(44832011)(6916009)(8936002)(31696002)(2906002)(6666004)(86362001)(186003)(38100700002)(2616005)(6486002)(83380400001)(316002)(16576012)(8676002)(36756003)(956004)(5660300002)(21314003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3ZocjVPalJuSGRLTHJTWlZxK0k5Ui9HRGpKYVVkdkdNM0Q5Vzlvcmt4eXRy?= =?utf-8?B?bG8vS2M3L0plT1ZyMGNhUmlDQStwVWVMK1NmOWMrU3VDak84Z011ekhVbGZL?= =?utf-8?B?NEhVUnp3U3JIMnFiRUNPODZBeDVEVXhXWkJwL29MV2g0cnZxaTFWa0JYL1Av?= =?utf-8?B?OHBobEpOa1lSYkxZL1F3bG4vRTRpakcvSk5aNStsQzZHMWM0ZHVOMkg2a1Aw?= =?utf-8?B?NS93YVJsUFFsZnRJeXk4SUllZ05HL0NyaHNWKzEvbEdBcnVaQ21ZL1Y2clJ1?= =?utf-8?B?eEw4UFg5b21mSXJaU3p4bEFiS1EwZUtiSy9GWFBXTjdWYmV5RDJiQTFqYmRC?= =?utf-8?B?a0tGczMvek54YzEzR21vL2FkVTYwQXhiNTRaZTF4aERFSG9PL0JkUUhYR1Yv?= =?utf-8?B?cjFzUzV5c0xHZ2VSa1pxVzU2c3JRdFIvRTE1SVNxejFyYUZwdFpuVTJWYTYw?= =?utf-8?B?b3JuNy9CRlRqSGs4VDNJU0thRm0zaTlpa2h5aWhpajBsOEdWMUN0QnBXSklL?= =?utf-8?B?SVM0bVBvZjFhcGtjRFdhc3VndHhqaEFzc0FueHhRdWVnT09kdVdmWHpPRkxl?= =?utf-8?B?bC8yV2ZnQnNBUnFtcWxhRW5oYXF4VFp5azE3ZjJYb3NWdXRBZDJYemJCTHZL?= =?utf-8?B?RDR1Nm1tSlVFR1VwVDlidVYyUFU5S3ZuT090cVo4aE1PZXllRWJYdUFpV2lZ?= =?utf-8?B?VFRMb1ByV3hwbTR2VFZQc1YzSWdyZHVaVWpmOU1jRE5LN3BWcjRpd0QwV2ty?= =?utf-8?B?cTFqT2w5TU1YVllyQ24yUWV1cTVPbDhNd1pZMEZxV09JMDdJZ25Jc1FLMFhu?= =?utf-8?B?STcramdGYTA0VmNaUE9SSnhYTENXcmhJM3NjTU4yaCtJVXZqbWhUWCtJZVhB?= =?utf-8?B?YWFOb3FKQU10eVlDTlhSa0RtMzYwRjZNSGQwOFdKZ0FJMHdsTkx6WGFyR3JW?= =?utf-8?B?MXVGNGR0dE9uaWtYa3pkTVY0UDlpVlZKU0RxNXRXQndxOHRNdGJaVzZaNldK?= =?utf-8?B?NHhFbjJrNThuVC9DVlRIbHFQMmx0MnExdVVIejBLSlhDdDBNN2tONmtYN3hN?= =?utf-8?B?TVBDMDM4RktLdm5vd25sOTRrSVVBNU1wWVo4TkpFUEU3bHdTdi9ZRGxWWERq?= =?utf-8?B?SEt4TlNZOTQ2eUFrR2laakpBSHRVRXdULzl0c2J2UDNGbU0wd2FIVDlYQ2RO?= =?utf-8?B?Y3NtZVBSQU1CSHIrZlBkQzBtR25lTWVHMmgzRWJTZkxkUW1GMU1oWWRUekhs?= =?utf-8?B?aVVsSEJMSkV6dkNwMm1MWWRSUlFEVUJCeHlBbkdldW1qYVJoUzk4OU5YY092?= =?utf-8?B?SDJsTk1lK3NhM2liamNod3VGTVdRb25SWFlzajhuRGlNU0ZxMHJQTWQ5NVB3?= =?utf-8?B?TVZ5NWdkbUp4dTRFaGRsaUt0SWdBZ0E0K0RuS2pXUXZSTGtPSmVJSnlVVVIv?= =?utf-8?B?MTQwOFJBZlRXZnFFc1lDTElxSnVRVDVIdk9IL0NZbHlMZVl0bkVtZWZrOFQ0?= =?utf-8?B?WWczU3pTUUI0eFhOVGFpRkI1R0dIQy9vQXp5SXlTWkdSSmwrWUpZekFmT0Ra?= =?utf-8?B?OXVmU2tFVk9QWkxsQk1zYkNPcnIraUlTOExkVUl4SkViNWI4YmFpN2FTVGdu?= =?utf-8?B?ZElFbHpYUmxEUk9Hc3lURU9EUFQzb0JUWUNJaTJlaDJhV0lBeUFUbm5zU2Zv?= =?utf-8?B?YlFjUHJJMTlyNlBSSktZU2pwb2w1ZW9kSkdJTzVTQU1lTTdkQ1BwSUVtaGRD?= =?utf-8?B?dkxDcm9POWR2RHVjRzNXbHoyMUZWZTQ4VlZoVTl2dnJLSlVOVm1XcTFWbHM4?= =?utf-8?B?ZTBBTHBRQnJvaUtjZlNHc20wNkJZcDZ5Zm1IdSt1RHNlR2RKREtGSjBmY1dl?= =?utf-8?B?Z2JiQTFyWExWRjlNYThqeXA4bnpsRnJXNXhSS2dMYWVvUDlyeCtCWXRXTEdi?= =?utf-8?B?MzRPMDgwU3VvZmQ5UTlZNFdZcDhIUzFDZEtKWnVSQ2NWaTJWUHgyRHFtT1ll?= =?utf-8?B?KzlxMTQvS2ttbk9sck5aZlAvUnQ5ckg2dGhtUHZ1WEEzNjBGM2VnVzJ2NWVR?= =?utf-8?B?UW9JOWFYUTY0ZTBLRW5jcElVVUpYN1ZDT3BnaTdudThMQSszQS9UektDK1pZ?= =?utf-8?B?QXVCM20rMmwreVhhQjlscVlIYStpeEVQbzdUd3dGYlZxclBWR2M1dnRXWFUw?= =?utf-8?Q?KSqM45S1zUkOPNygPcLRqvE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b371cd2b-3f71-4968-308d-08d99df9815c X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 12:08:39.4944 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rsDCZRiwIXoKjDXXf6bVxKi8SHd6H+wINSCOkF9T0Va9e3s0mrDHEcstzVXgEjYQ5i5VsXNgBsAU6K+fde6/YQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5861 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/2] devtools: disable fixes authors in get maintainers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2021 11:28 AM, Thomas Monjalon wrote: > 02/11/2021 11:04, Ferruh Yigit: >> On 11/1/2021 10:20 PM, Thomas Monjalon wrote: >>> 01/11/2021 14:35, Ferruh Yigit: >>>> 'get_maintainer.pl' by default returns authors that has fixes in >>>> relevant code, to reduce the output only maintainers from MAINTAINERS >>>> file, disabling fixes authors, by making '--no-fixes' default. >>> >>> Do you mean it is not Cc'ing people who have contributed to the file? >>> Is it keeping Cc of people having contributed to the commit being fixed? >>> >> >> It is adding both, people contributed to the file and contributed to the commit >> it is fixing. More details from tool is below [1]. >> >> Intention to cc'ing the people who introduced the commit you are fixing >> makes sense. >> But as far as I can see it adds all xxx-by names from the fix commit, not >> just author, that may add some unrelated people. >> >> Let me give a sample: >> Commit A: ("ethdev: add namespace") >> It updates bunch of drivers and it has acks from various >> driver maintainers. >> >> Commit B: ("net/txgbe: fix link macro") >> Fixing Commit A for one driver (txgbe) >> >> If --fixes is used on 'Commit B', the author of 'Commit A' and all people >> acked 'Commit A' is added. But none of the acks were related to 'Commit B'. >> So as a result unrelated people cc'ed for 'Commit B'. >> >> >> If the commit and fix commit are more narrow scope, this make sense. >> So we may prefer to keep '--fixes' if we are OK to some noises in some cases. > > Yes I prefer Cc'ing everybody. > In case where the people are not needed for sure, I don't use the script. > OK to drop this patch, but I think good to have first one (1/2). > >> [1] >> From 'get_maintainer.pl': >> --fixes => for patches, add signatures of commits with 'Fixes: ' (default: 1 (on)) >> >> >> And form commit log that adding the feature: >> 2f5bd343694e ("scripts/get_maintainer.pl: add signatures from Fixes: lines in commit message") >> >> A Fixes: lines in a commit message generally indicate that a previous >> commit was inadequate for whatever reason. >> >> The signers of the previous inadequate commit should also be cc'd on >> this new commit so update get_maintainer to find the old commit and add >> the original signers. >> >