From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 5FB061B68E
 for <dev@dpdk.org>; Tue,  3 Apr 2018 12:16:53 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id AC7EF21A17;
 Tue,  3 Apr 2018 06:16:52 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Tue, 03 Apr 2018 06:16:52 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=JYVnflM52fFH6KwTUheSRDG785
 oyt3ZUjTKQ6qz0fRI=; b=bkcidTs3Ov0i9CUztON3lWePl7NqHAGw5QjAPFQBYC
 QTjes2QZwEyTQ9XnMAPwXvlN85/lKeKT3i4JbKnPYsG8MwHhCzpW5IMit6LHi8vc
 YXsvhsDeOW4NvCy1+xk/iALBpZZ+6OSvx3RfV7ySme5J9/75em90tcGZKXiUPdrp
 U=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=JYVnfl
 M52fFH6KwTUheSRDG785oyt3ZUjTKQ6qz0fRI=; b=jKgKQHIDKyg3rmKXf+y2CF
 eUebbCVL0PGwgH8XxWPWU0eDrmoZbgQVLLtmDTAvJndFm9fpA0hQLF83Pqv5M1y4
 iMMOuSGiwmzXbC5w9FsvWg31S1f2wHgrzXd2FI+UQh9aL+nuZ8wtdmdNlYOJrqOa
 Iq5gDX+yPGqij+ujRcFSzl0ho5hId/c5YmKtCKVqnzSSARrzEMgdDopEjIjTYiUn
 l6Cnf+ZncnYEFiFCogShC0MmJAT4gUsU4sJhEpNu+/gPv8uXH3z6nHzfkdrFwbfL
 F55P7xpWQLkwd93h8M++ZaPhe0QTN7c483Rd2Qb/O5mk3FGAielGozE1b3mQZdwA
 ==
X-ME-Sender: <xms:lFTDWvkqtNGSC5applIdQpUNH5D6iMOTRz3muj-hMyjqe_EzUL4K7Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 8E308E444F;
 Tue,  3 Apr 2018 06:16:51 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
 Neil Horman <nhorman@tuxdriver.com>,
 =?ISO-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>,
 Tonghao Zhang <xiangxia.m.yue@gmail.com>,
 Timothy Redaelli <tredaelli@redhat.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Ferruh Yigit <ferruh.yigit@intel.com>
Date: Tue, 03 Apr 2018 12:13:11 +0200
Message-ID: <30459437.oZxcDd1rdk@xps>
In-Reply-To: <02f1e234-e02c-332c-bf09-77584621cef1@redhat.com>
References: <a28e7585-c312-8b0e-4e6d-1f6621a35feb@solarflare.com>
 <20180402092515.3e5ccea4@xeon-e3>
 <02f1e234-e02c-332c-bf09-77584621cef1@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] Build is broken in dpdk-next-net
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Apr 2018 10:16:53 -0000

03/04/2018 10:31, Maxime Coquelin:
> On 04/02/2018 06:25 PM, Stephen Hemminger wrote:
> > Rather than wallpapering over the unused result, why not do real error checking?
> > If the program was run in a non-Linux environment (such as WSL etc), maybe an error
> > could occur. Best to return an error; or at least call rte_exit().
> > 
> 
> Do we really want to call rte_exit() in a library?

No, we must use return.