From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B746842572; Mon, 11 Sep 2023 21:11:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49598402E7; Mon, 11 Sep 2023 21:11:50 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 6E8E7402E4 for ; Mon, 11 Sep 2023 21:11:48 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id B53273200786; Mon, 11 Sep 2023 15:11:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 11 Sep 2023 15:11:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1694459506; x=1694545906; bh=q7aqcYy7dXNobe9zp1Wn29G845hS5eTr+ML tdCd25ac=; b=CBTsTUc96excUeG+SCLjFe2aD8p9BTJJ/kLS8kw9m8s10EpUmVr S2EdlBztEFcV4Pg/FYuSjDzpcPoS9g5+Y0ryz8InS+p5aeOt7pyRTzRn159bN+PK JKNP8ohgaxS/7NzkKqZ9iBL+rw/BWZ4Gy/VjkSFXEex8dTbPrOcOj8QyXJ83tKBp iYF4EOlifXLZcUobX4I+xJF17NyyFm3C/reqesnv9oGThvG0S1nQELVRlm9jkKnI duVBwDWodEUxbMVVC5cwlQYj1ZF+OMNXZbvY+XP419Hluxg5r1KdmagnIvGgiRVc jOL5eqjWuHk+n4MzqwsACIthG1JrMbBuTEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1694459506; x=1694545906; bh=q7aqcYy7dXNobe9zp1Wn29G845hS5eTr+ML tdCd25ac=; b=Hn88snhaw+wmdRnX6Eu/e01I37jfAqnYP+nNb+0nGjQXyJrCqui Ml+wtNVTEOTYX9gBuOXZL495aofNdjSfXkqOwIVaEnQ5xdrsdTcwjaiHPOlYAEXP jB11x1vbfm+x3//RvlIiTPTuSa7DrhEffYckVAbLCOHV1gmopJhmme79gHRX1bE2 TQa6SdaUO0cd7EtCbcL6jkjzjKdbx0JCDz7uKUIp391znTZjvKarBwAdIG2Y7bCh PYPDoRPMKWLD+HJwuihH/FuUEQTgTcGi6w9mm3HTQvZD8ssqKteNepOrTSbQt2hv 11udMuhMinA8UwrQaE5/niR4FP3YFvibgmQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudeigedgudefudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 11 Sep 2023 15:11:43 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, David Marchand , Ferruh Yigit , Anatoly Burakov , Bruce Richardson , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Subject: Re: [PATCH 10/11] eal: remove deprecated thread functions Date: Mon, 11 Sep 2023 18:13:48 +0200 Message-ID: <3054789.ktpJ11cQ8Q@thomas> In-Reply-To: <20230908042256.GF7692@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230906162226.1618088-1-thomas@monjalon.net> <20230906162226.1618088-11-thomas@monjalon.net> <20230908042256.GF7692@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 08/09/2023 06:22, Tyler Retzlaff: > On Wed, Sep 06, 2023 at 06:12:27PM +0200, Thomas Monjalon wrote: > > --- a/lib/eal/common/eal_common_thread.c > > +++ b/lib/eal/common/eal_common_thread.c > > @@ -248,7 +248,7 @@ struct rte_thread_ctrl_params { > > enum __rte_ctrl_thread_status ctrl_thread_status; > > }; > > the code above here > > struct rte_thread_ctrl_params i think can now get renamed to > rte_thread_control_params and i think we can get rid of the union. > if i look through the code history i only added it to help maintain > compatibility while we had both ctrl and control thread APIs. Yes I can do this cleanup. Instead of rte_thread_control_params, I would call it control_thread_params as it is private.