From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34A71A04C7; Tue, 15 Sep 2020 18:42:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EEEFE1C113; Tue, 15 Sep 2020 18:42:16 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 4A3D41C10D for ; Tue, 15 Sep 2020 18:42:15 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id EEDDB9C0; Tue, 15 Sep 2020 12:42:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 15 Sep 2020 12:42:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= yhy09uI2aeDwj5FAWmi3PK5ZGOut9O4o9coXqe6Nqhs=; b=GTBnO4s15gwKDoLf 7XFrMBzoaiTXzWlChl3IaUrDlEbzW6cFWQZBFvImPv7KY5Ofr0c38HN9frC9jkYZ 2Nmo/teF+2gBKTd0Gk6G0ziwOc1m9azWByQMoGJa0P26mW7OYL8qa002gysF8Yr6 0ciF+3OM/J/BiZvb0dwZdk5b6o53ct5JpH7LKnrtL2KdQBRKNM0zi/7EceLnJy6L hU75X+mo/ilmOlhY8lVI/EelSFsx3LAVhln3OlbFLs7Dj0wuDA0w5LITOQ5oxmQa Q8BRIFLe0u3iZW/2jjupKuCNPNiSwisw1slYl5R1lAC7p/0atj0HrtAoX736Th4X MJoULg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=yhy09uI2aeDwj5FAWmi3PK5ZGOut9O4o9coXqe6Nq hs=; b=ePZswVhf5TEshmz6wrjWATsxd/I5jupOVRx4DvfZ3bGSOBFfvsyheSkB6 dBVc+uABlKNbrCURNAHF4BXBx8y5Lj3qNcHxda6S4p4zPYD2WT+gvzR0loGnc6I3 LTsQVyTImu1HN6Uz46NiRGN7YyAYbsPkc0nxvlOBo71/NdgYLYCgUwz1zQ06aw+1 0LAQ2qptUrUE3B6XbMSmivHU9z9+e/d/5+KR+MISqi6VutoRADL/uaa7GfCzBpzh 4bdYuDDs9EFwh+M20YKEJ7qgxnMttPGVeaBYKvlnLIFiIsZndgTCriHXGhalxmLZ avFhfnGchO2ogkCu9YrcNzQGKvyzg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrtddtgdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C8A7F3064685; Tue, 15 Sep 2020 12:42:12 -0400 (EDT) From: Thomas Monjalon To: David Marchand , "Power, Ciara" , "Richardson, Bruce" , "Chautru, Nicolas" Cc: dev Date: Tue, 15 Sep 2020 18:42:10 +0200 Message-ID: <3056438.bxcqElY2t2@thomas> In-Reply-To: References: <20200903152717.42095-1-ciara.power@intel.com> <6470705.gZyV2GM0uM@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 00/31] remove make support in DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/09/2020 18:39, Chautru, Nicolas: > Hi, > > > From: Thomas Monjalon > > Sent: Tuesday, September 15, 2020 9:11 AM > > To: David Marchand ; Chautru, Nicolas > > ; Power, Ciara ; > > Richardson, Bruce > > Cc: dev > > Subject: Re: [PATCH v4 00/31] remove make support in DPDK > > > > 15/09/2020 17:57, Richardson, Bruce: > > > > > > > -----Original Message----- > > > > From: Thomas Monjalon > > > > Sent: Tuesday, September 15, 2020 4:44 PM > > > > To: David Marchand ; Chautru, Nicolas > > > > ; Power, Ciara > > > > Cc: Richardson, Bruce ; dev > > > > > > > > Subject: Re: [PATCH v4 00/31] remove make support in DPDK > > > > > > > > 15/09/2020 17:08, Power, Ciara: > > > > > Hi David, > > > > > > > > > > > > > > > >-----Original Message----- > > > > > >From: David Marchand > > > > > >Sent: Tuesday 15 September 2020 15:03 > > > > > >To: Thomas Monjalon ; Chautru, Nicolas > > > > > > > > > > > >Cc: Richardson, Bruce ; dev > > > > > >; Power, Ciara > > > > > >Subject: Re: [PATCH v4 00/31] remove make support in DPDK > > > > > > > > > > > >On Tue, Sep 8, 2020 at 11:05 AM Thomas Monjalon > > > > > > > > > > > >wrote: > > > > > >> > > > > > >> 08/09/2020 10:16, Bruce Richardson: > > > > > >> > On Tue, Sep 08, 2020 at 12:06:40AM +0200, Thomas Monjalon > > wrote: > > > > > >> > > The first 13 commits of this series are pushed to the main > > > > > >> > > branch, making the make-based build an old story. > > > > > >> > > > > > > > >> > > The last 18 commits (devtools, app and doc) are pending for > > > > > >> > > more reviews, especially because the doc rework is still in > > > > progress. > > > > > >> > > This is a big change which requires to be split but must be > > > > > >> > > completed soon. > > > > > >> > > *All*, please make the documentation update your highest > > > > priority. > > > > > >> > > I will be reluctant to merge some driver changes if the > > > > > >> > > related doc is not updated. > > > > > >> > > > > > > > >> > Thanks for the apply of the code patches, I think it will > > > > > >> > make all our subsequent patch submissions a bit cleaner. > > > > > >> > > > > > > >> > In terms of docs, I believe the Linux and FreeBSD GSG guides > > > > > >> > to be ready for merge, or if not 100% they are at least good > > > > > >> > enough IMHO to be applied now and have some minor tweaks in > > > > > >> > subsequent patches later. While I'm sure the Linux GSG could > > > > > >> > do with more major rework, that should be separate from the > > > > > >> > doc updates in this > > > > patch. > > > > > >> > > > > > >> Of course I am not expecting any major rework in these patches, > > > > > >> but I don't want to apply clean-up half done, which can drop > > > > > >> some relevant informations or introduce mistakes. > > > > > >> > > > > > >> I will review the Linux and FreeBSD user guides first, as you > > > > suggest. > > > > > > > > > > > >I could not find a patch in patchwork for > > > > > >app/test-bbdev/test-bbdev.py which still references RTE_SDK and > > > > RTE_TARGET. > > > > > > > > > > > > > > > > > >-- > > > > > >David Marchand > > > > > > > > > > > > > > > Changes to test-bbdev.py were made in patch 15: > > > > https://patchwork.dpdk.org/patch/76796/ to remove the references to > > > > RTE_SDK and RTE_TARGET. > > > > > > > > I did not merge this patch because it is hardcoding "build" as a > > > > directory. > > > > I'm sure we can do better. > > > > > > > > > > We probably can, but is it really worth holding up the patch over something as > > trivial as that? It is really likely to cause people issues? > > > > I give one more week to Nicolas to better fix this script. > > If not, I will merge that patch as is. > > > > Hi Thomas, Ciara, > I had raised that concern a couple of weeks ago but I was personally satisfied with document pointing to `build` as default staging build directory and seeing limited reason in practice for it to be impactful for bbdev users. > Also the argument to the script `-p` can be used to bypass default path to any location. > See reply here https://patches.dpdk.org/patch/76426/ > The only request I had was to change the default name of the binary (mentioned on same link above) and I don't see that change being made (I may just miss the superseding patch though) You're right, I remember it was the other reason for not merging. In any case, I will wait for Ack from Nicolas.