From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 6817C5A7A
 for <dev@dpdk.org>; Thu, 16 Jul 2015 01:06:20 +0200 (CEST)
Received: by wgjx7 with SMTP id x7so44711642wgj.2
 for <dev@dpdk.org>; Wed, 15 Jul 2015 16:06:20 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=fcg1u/7HWGtMe4ZmqbnCOzwPzpuu/dNCC4AD5ZS1L5g=;
 b=mrwRlycICLFRln2Sdy4Ok6f4bKs1yuh9fx4fxeYd5Rch30Z6CwXMAUHTVBJqSYFfaw
 eIw+IEvw3cgntSyv1Ndl6capqta/plFMjqnaGdwH+jauZ+N1PG6rT1zs1o2tyDi2nmY5
 9N4MltHlYcf+MJuo/Wjau8QosffYEPvuvfFWPiiqLGuoe++Bo6ao+lfd/SCwOqyv49m6
 1BMvPYRfRmEXuWEdE6yx5Xg3jDETdhGDEK72DD41evcc6IlIuKKW1B670W5HVSJXvEWG
 G+V6nqjg9UfNAz3IizrG6GuTM2O6jmpvfto5RP9DQYSZRxAmBck5ryOhGfz3Z2+7zPzh
 nPJA==
X-Gm-Message-State: ALoCoQk0DXOnSdu1mVk7nkxw/++3J4Nq6hM94/2lsUq8rwFuFkrYKNOXpuHvfWdPixgiweBsfsIg
X-Received: by 10.180.86.73 with SMTP id n9mr892167wiz.78.1437001580237;
 Wed, 15 Jul 2015 16:06:20 -0700 (PDT)
Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net.
 [82.235.116.147])
 by smtp.gmail.com with ESMTPSA id ju2sm189813wid.12.2015.07.15.16.06.17
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 15 Jul 2015 16:06:18 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Date: Thu, 16 Jul 2015 01:05:07 +0200
Message-ID: <30575439.VDcg1RVFpr@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8950A0@SHSMSX104.ccr.corp.intel.com>
References: <2161590.Y1eMLetJSj@xps13>
 <1436981535-15539-1-git-send-email-thomas.monjalon@6wind.com>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8950A0@SHSMSX104.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mlx4: replace some offload flags with packet
	type
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jul 2015 23:06:20 -0000

2015-07-15 18:06, Zhang, Helin:
> > The workaround for Tx tunnel offloading can now be replaced with packet type
> > flag checking.
> > The ol_flags for IPv4/IPv6 and tunnel Rx offloading are replaced with packet type
> > flags.
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
[...]
> > +	uint32_t pkt_type = 0;
> Initial value of 0 seems not needed.
> 
> > +
> > +	if (flags & IBV_EXP_CQ_RX_TUNNEL_PACKET)
> > +		pkt_type |=
> Operand of 'OR' is not needed at all.

Matter of taste (OR allows to add more flags before).

Applied with above changes.