From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DB53A046B for ; Fri, 28 Jun 2019 11:17:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C5BF4C8E; Fri, 28 Jun 2019 11:17:12 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 6C7231E2F; Fri, 28 Jun 2019 11:17:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id C27753BF; Fri, 28 Jun 2019 05:17:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 28 Jun 2019 05:17:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=m3bRVr9WTgXPcKD2dxPj5iGqfPrAl8JiueyxTwFLJgM=; b=WRn5RCgrNRsC Z40Tzzu3Po5JcLDKjkNlelRAnF4IctjN7gJP+DNzM7kH1v0dNi6Ajd871c9BXFyv b3tDObOKTsCHAQCtiEMpjg/7xf7VQTQN0YgsexA3nRe7RbdRj4DmHl+X8L36awyg QWqo/O1fJYdxx3TTWc5pFhvCjezW0IU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=m3bRVr9WTgXPcKD2dxPj5iGqfPrAl8JiueyxTwFLJ gM=; b=mEvuHxTu2JyEoALZVdW33Uli2SgSRecVC0QwsZ1BC1arzQh+4iPLQU6tI oZ8jEhx0NriEJQqOEQXHbPdlFxS2PT+mkOrO3LOBSGL6VkBPslkLhQfY7Vl2QQPN rGn6HxnHmfLPH4Ikqrngv5ARSodymF5GcK3BkCMItoZNDNOHr/+QdpdyjFR+saXD tCRFQZffWKHs6p7WpAhuvblXretOg7aMmCfpyFEDTZ/7c2qiorfwAh/ce9iAi0ec z8R1BBrfCSzSWMGdNZjZkGOlUpUfEVjrvMpuvqZWl1PiqNxPN2BG5WlV4AP+ygPg itF/ajh7L29PyVBsgiL8vXb756HyA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrvddtgdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 413EA380079; Fri, 28 Jun 2019 05:17:07 -0400 (EDT) From: Thomas Monjalon To: "Laatz, Kevin" , Ferruh Yigit Cc: dev@dpdk.org, stable@dpdk.org, Reshma Pattan , Flavia Musatescu Date: Fri, 28 Jun 2019 11:17:06 +0200 Message-ID: <3057664.AIUAmKyhIq@xps> In-Reply-To: <114e7aba-06da-75b0-3459-7bac9c4119f1@intel.com> References: <20190627195144.89720-1-ferruh.yigit@intel.com> <114e7aba-06da-75b0-3459-7bac9c4119f1@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] telemetry: fix build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/06/2019 10:46, Laatz, Kevin: > > On 27/06/2019 20:51, Ferruh Yigit wrote: > > Build error: > > ../lib/librte_telemetry/rte_telemetry.c:558:28: > > error: comparison of unsigned expression < 0 is always false > > [-Werror,-Wtautological-compare] > > > > Build error not observed in default make build because telemetry library > > disabled by default but easier to reproduce via meson. No, I compile telemetry with make and with meson. I cannot reproduce the error. I guess it depends of the compiler version? > > Fixing by converting unsigned variables to signed. > > > > Fixes: 0fe3a37924d4 ("telemetry: format json response when sending stats") > > Fixes: 4080e46c8078 ("telemetry: support global metrics") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ferruh Yigit > > --- > > Cc: Reshma Pattan > > Cc: Flavia Musatescu > > --- > > lib/librte_telemetry/rte_telemetry.c | 12 ++++++------ > > lib/librte_telemetry/rte_telemetry_internal.h | 6 +++--- > > 2 files changed, 9 insertions(+), 9 deletions(-) > > Acked-by: Kevin Laatz Applied, thanks