From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B179A0A0A; Thu, 3 Jun 2021 10:43:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 073C740FDF; Thu, 3 Jun 2021 10:43:37 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id C45BD40DF6 for ; Thu, 3 Jun 2021 10:43:34 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6C8115C0069; Thu, 3 Jun 2021 04:43:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 03 Jun 2021 04:43:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= VdA2eMZRNoeGeGxdmlYRgX39sBfTzmiOeyyu4aLXcSg=; b=cjooroVq6fXWKGxU VrpCjmWq/pUXykGpBy8W+JNWzXBp/EXhxUJAgDcD784AP80z0+BVXthiNdP0M0a/ 2+F8g3AfBoaBQuKBEKVUTzSpza3akO8VwARD6lek/+WqJllSr5Zh3tq/QNPd0jKQ GlScePP/dPAU0K1oogI15MicS8FqEYnh8ALt2PnikXSIeu3VGX49EhaqOf3xIZl/ LFC8fZ8+7MVaJA/QCUkt5JmoOtQd1u9w4AYMgQL2A4N0tExMkoCM07LNisygem1H FyJ5g97i18h795/K7bEKVZ5UQiYf8xyVxlzO6xjSCfybIF5qRHC3w8UOnmNnRwpk KweRig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=VdA2eMZRNoeGeGxdmlYRgX39sBfTzmiOeyyu4aLXc Sg=; b=gBN8ZlnFq7AJAAwMq8UKt1I+OHFy/+y41BuPiSQNDQqkkvfUnoj/CdOKG mazhIcFY3PBYo/LAiot9s5r8VOqNlPvq6OEMrCXWC6jsX5ElhS2VdxrpudQWRMGA zznyA1hQuI4Zac8M8RZ4HXNoHAbGQST52D5RLkoD7Vm0zd4i4DQFmeHY1iMzxlja i1PidXQm52Fw0STNhUO7CAxYEIs43Qi/TxBs1gs63c+qhG/ByjYLgDpSnJ+5zCn0 55w8qcDTDO6lnXbh3gJOf5VcqQLp7+tzC4Lv+kkcIpfOAf6wwsulbmSYemJC0x/e mqV+WkrKQBxTQ6wKSG7jGuFt2Lp+A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdelledgtdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 3 Jun 2021 04:43:33 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: dpdk-dev , Elena Agostini Date: Thu, 03 Jun 2021 10:43:32 +0200 Message-ID: <3058202.9UA1LLGnyJ@thomas> In-Reply-To: References: <20210602203531.2288645-1-thomas@monjalon.net> <2066767.2bDh9DmJd4@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] gpudev: introduce memory API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/06/2021 10:41, Jerin Jacob: > On Thu, Jun 3, 2021 at 1:58 PM Thomas Monjalon wrote: > > > > 03/06/2021 09:47, Jerin Jacob: > > > On Thu, Jun 3, 2021 at 2:05 AM Thomas Monjalon wrote: > > > > --- a/doc/api/doxy-api-index.md > > > > +++ b/doc/api/doxy-api-index.md > > > > @@ -21,6 +21,7 @@ The public API headers are grouped by topics: > > > > [compressdev] (@ref rte_compressdev.h), > > > > [compress] (@ref rte_comp.h), > > > > [regexdev] (@ref rte_regexdev.h), > > > > + [gpudev] (@ref rte_gpudev.h), > > > > > > Since this device does not have a queue etc? Shouldn't make it a > > > library like mempool with vendor-defined ops? > > > Any specific reason for making it a device? The reason why I am asking > > > this is, as other DPDK devices as symmetry in queue(s), configure, > > > start, stop operation etc. > > > > > > > > > > + > > > > +struct rte_gpu_dev { > > > > + /* Backing device. */ > > > > + struct rte_device *device; > > > > > > See above? > > > > There is a PCI device probed. > > I don't understand why it would not be represented as a device. > > All other DPDK device has symmetry in structures like queue and > symmetry in operation like it has configure, start, stop etc. > This one seems more like mempool to me all we want set of > vendor-defined ops. So any justification on > make it a device ? why not like mempool library? > (driver/mempool/octeontx2 Mempool HW is also PCI device, but > we don't take device path for mempool. So I would like to understand > any technical reason for making it a device). I don't understand what you mean by "symmetry".